Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2721433002: Revert of Removing unused audio device tests (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Removing unused audio device tests (patchset #1 id:1 of https://codereview.webrtc.org/2716843002/ ) Reason for revert: I unfortunately have to revert this since trybots are still trying to run these tests and now they fail because the tests aren't there :-/ Before relanding, can you work with engprod to make sure we don't run them? Original issue's description: > Removes a test suite that is no longer used or maintained. > > BUG=NONE > > Review-Url: https://codereview.webrtc.org/2716843002 > Cr-Commit-Position: refs/heads/master@{#16825} > Committed: https://chromium.googlesource.com/external/webrtc/+/bb5136f9403833d764504df4b80a38167e49f0cb TBR=solenberg@webrtc.org,nisse@webrtc.org,henrika@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=NONE Review-Url: https://codereview.webrtc.org/2721433002 Cr-Commit-Position: refs/heads/master@{#16845} Committed: https://chromium.googlesource.com/external/webrtc/+/3dda246b69df7ff489660e0aee0378210104240b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1711 lines, -1 line) Patch
M webrtc/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/modules/audio_device/test/audio_device_test_api.cc View 1 chunk +1609 lines, -0 lines 0 comments Download
A webrtc/modules/audio_device/test/audio_device_test_defines.h View 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tommi
Created Revert of Removing unused audio device tests
3 years, 9 months ago (2017-02-26 14:27:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2721433002/1
3 years, 9 months ago (2017-02-26 14:27:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/3dda246b69df7ff489660e0aee0378210104240b
3 years, 9 months ago (2017-02-26 15:12:55 UTC) #6
henrika_webrtc
lgtm
3 years, 9 months ago (2017-02-27 08:15:29 UTC) #7
henrika_webrtc
3 years, 9 months ago (2017-02-28 08:40:51 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2720173004/ by henrika@webrtc.org.

The reason for reverting is: The test should no longer be executed on any bot
and it is therefore safe to remove it again..

Powered by Google App Engine
This is Rietveld 408576698