Removing unused audio device tests

Removes a test suite that is no longer used or maintained.

BUG=NONE

Review-Url: https://codereview.webrtc.org/2716843002
Cr-Commit-Position: refs/heads/master@{#16825}
Committed: https://chromium.googlesource.com/external/webrtc/+/bb5136f9403833d764504df4b80a38167e49f0cb

[henrika_webrtc, 2017-02-24 10:29:18]

Description was changed from

==========
Removing unused audio device tests

format nit


Removing unused audio device tests

BUG=
==========

to

==========
Removes a test suite that is no longer used or maintained.

BUG=NONE
==========

[henrika_webrtc, 2017-02-24 10:29:18]

henrika@webrtc.org changed reviewers:
+ nisse@webrtc.org, solenberg@webrtc.org

[henrika_webrtc, 2017-02-24 10:29:42]

The CQ bit was checked by henrika@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 10:29:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-24 11:12:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 11:12:30]

Dry run: This issue passed the CQ dry run.

[henrika_webrtc, 2017-02-24 11:17:08]

PTAL

[nisse-webrtc, 2017-02-24 11:24:56]

lgtm

[the sun, 2017-02-24 11:31:49]

lgtm

[henrika_webrtc, 2017-02-24 11:33:21]

The CQ bit was checked by henrika@webrtc.org

[commit-bot: I haz the power, 2017-02-24 11:33:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-24 11:36:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487936001229180, "parent_rev":
"8fbe14183db9d85d5c7193ab0cbbd6d398db280b", "commit_rev":
"bb5136f9403833d764504df4b80a38167e49f0cb"}

[commit-bot: I haz the power, 2017-02-24 11:36:26]

Description was changed from

==========
Removes a test suite that is no longer used or maintained.

BUG=NONE
==========

to

==========
Removes a test suite that is no longer used or maintained.

BUG=NONE

Review-Url: https://codereview.webrtc.org/2716843002
Cr-Commit-Position: refs/heads/master@{#16825}
Committed:
https://chromium.googlesource.com/external/webrtc/+/bb5136f9403833d764504df4b...
==========

[commit-bot: I haz the power, 2017-02-24 11:36:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/bb5136f9403833d764504df4b...

[tommi, 2017-02-26 14:27:08]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2721433002/ by tommi@webrtc.org.

The reason for reverting is: I unfortunately have to revert this since trybots
are still trying to run these tests and now they fail because the tests aren't
there :-/  Before relanding, can you work with engprod to make sure we don't run
them?.

[tommi, 2017-02-26 14:29:54]

tommi@webrtc.org changed reviewers:
+ tommi@webrtc.org

[tommi, 2017-02-26 14:29:55]

https://codereview.webrtc.org/2716843002/diff/1/webrtc/modules/audio_device/B...
File webrtc/modules/audio_device/BUILD.gn (left):

https://codereview.webrtc.org/2716843002/diff/1/webrtc/modules/audio_device/B...
webrtc/modules/audio_device/BUILD.gn:324: rtc_executable("audio_device_tests") {
It's really strange that the trybots happily ran these tests anyway :-/
E.g.

https://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/1...

[kjellander (google.com), 2017-02-28 00:21:15]

On 2017/02/26 14:29:55, tommi (webrtc) wrote:
>
https://codereview.webrtc.org/2716843002/diff/1/webrtc/modules/audio_device/B...
> File webrtc/modules/audio_device/BUILD.gn (left):
> 
>
https://codereview.webrtc.org/2716843002/diff/1/webrtc/modules/audio_device/B...
> webrtc/modules/audio_device/BUILD.gn:324: rtc_executable("audio_device_tests")
{
> It's really strange that the trybots happily ran these tests anyway :-/
> E.g.
> 
>
https://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/1...

They probably picked up a previously compiled binary. We don't clobber builds,
so that's a price we pay because of that.

I'm just curious : you're removing the test only here - is the production code
still around? If so - why delete the test? Or is it covered by other tests?

[tommi, 2017-02-28 00:42:38]

On 2017/02/28 00:21:15, kjellander (google.com) wrote:
> On 2017/02/26 14:29:55, tommi (webrtc) wrote:
> >
>
https://codereview.webrtc.org/2716843002/diff/1/webrtc/modules/audio_device/B...
> > File webrtc/modules/audio_device/BUILD.gn (left):
> > 
> >
>
https://codereview.webrtc.org/2716843002/diff/1/webrtc/modules/audio_device/B...
> > webrtc/modules/audio_device/BUILD.gn:324:
rtc_executable("audio_device_tests")
> {
> > It's really strange that the trybots happily ran these tests anyway :-/
> > E.g.
> > 
> >
>
https://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/1...
> 
> They probably picked up a previously compiled binary. We don't clobber builds,
> so that's a price we pay because of that.
> 
> I'm just curious : you're removing the test only here - is the production code
> still around? If so - why delete the test? Or is it covered by other tests?

good point... do these tests cover audio_device_core_win.cc?

[henrika_webrtc, 2017-02-28 09:14:33]

These tests are very old and come from a time when we tested each method in the
ADM as if the ADM should function as a standalone component.
Several tests are already disabled and we test combinations of APIs that are no
longer valid (since the ADM is now used in a more fixed way in VoE).
The tests does not verify media (we have other tests under
voice_engine/test/auto_test) which starts media and verifies that it works OK.
There are also a a more extensive set of ADM tests for Android and iOS.
You could also say that these tests tests the most "hardware related parts of
the ADM", but not those that we expose via the VoEHardware API.
Hence, not much value to maintain them imo.