Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2720773002: Reland of Use TaskQueue in IncomingVideoStream (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Use TaskQueue in IncomingVideoStream (patchset #1 id:1 of https://codereview.webrtc.org/2714393003/ ) Use TaskQueue in IncomingVideoStream instead of the PlatformThread + event timer approach. TBR=mflodman@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7219, webrtc:7253 Reland of https://chromium.googlesource.com/external/webrtc/+/686aa37382428bc667adff8cd6895674cae4e5fd (revert) https://chromium.googlesource.com/external/webrtc/+/e2d1d6429557af4560a97581a5e282b54c742173 (original) Review-Url: https://codereview.webrtc.org/2720773002 Cr-Commit-Position: refs/heads/master@{#16872} Committed: https://chromium.googlesource.com/external/webrtc/+/ede0759c041715646f70ce4eb1fc85d69c963d18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -99 lines) Patch
M webrtc/base/task_queue_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/common_video/include/incoming_video_stream.h View 2 chunks +8 lines, -19 lines 0 comments Download
M webrtc/common_video/incoming_video_stream.cc View 2 chunks +44 lines, -67 lines 0 comments Download
M webrtc/common_video/video_render_frames.h View 2 chunks +5 lines, -8 lines 0 comments Download
M webrtc/common_video/video_render_frames.cc View 6 chunks +27 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
tommi
Created Reland of Use TaskQueue in IncomingVideoStream
3 years, 9 months ago (2017-02-27 15:14:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2720773002/1
3 years, 9 months ago (2017-02-27 15:16:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/ede0759c041715646f70ce4eb1fc85d69c963d18
3 years, 9 months ago (2017-02-27 15:16:14 UTC) #7
mflodman
3 years, 9 months ago (2017-02-27 15:25:08 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698