Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2714393003: Revert of Use TaskQueue in IncomingVideoStream (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Use TaskQueue in IncomingVideoStream (patchset #10 id:320001 of https://codereview.webrtc.org/2716473002/ ) Reason for revert: Reverting while fixing build issue in Chromium. Original issue's description: > Use TaskQueue in IncomingVideoStream instead of the PlatformThread + event timer approach. > > BUG=webrtc:7219, webrtc:7253 > > Review-Url: https://codereview.webrtc.org/2716473002 > Cr-Commit-Position: refs/heads/master@{#16860} > Committed: https://chromium.googlesource.com/external/webrtc/+/e2d1d6429557af4560a97581a5e282b54c742173 TBR=mflodman@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7219, webrtc:7253 Review-Url: https://codereview.webrtc.org/2714393003 Cr-Commit-Position: refs/heads/master@{#16863} Committed: https://chromium.googlesource.com/external/webrtc/+/686aa37382428bc667adff8cd6895674cae4e5fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -93 lines) Patch
M webrtc/base/task_queue_unittest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/common_video/include/incoming_video_stream.h View 2 chunks +19 lines, -8 lines 0 comments Download
M webrtc/common_video/incoming_video_stream.cc View 2 chunks +67 lines, -44 lines 0 comments Download
M webrtc/common_video/video_render_frames.h View 2 chunks +8 lines, -5 lines 0 comments Download
M webrtc/common_video/video_render_frames.cc View 6 chunks +5 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tommi
Created Revert of Use TaskQueue in IncomingVideoStream
3 years, 9 months ago (2017-02-27 13:10:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2714393003/1
3 years, 9 months ago (2017-02-27 13:10:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/686aa37382428bc667adff8cd6895674cae4e5fd
3 years, 9 months ago (2017-02-27 13:10:40 UTC) #6
tommi
3 years, 9 months ago (2017-02-27 15:14:05 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2720773002/ by tommi@webrtc.org.

The reason for reverting is: Reland now that Chromium has been updated..

Powered by Google App Engine
This is Rietveld 408576698