Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2719743002: Enable GN check for webrtc/common_audio (Closed)

Created:
3 years, 9 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable GN check for webrtc/common_audio BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2719743002 Cr-Commit-Position: refs/heads/master@{#16946} Committed: https://chromium.googlesource.com/external/webrtc/+/50550e1440f28e45d443a0563d0bb16b579af2d1

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M .gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_audio/BUILD.gn View 1 7 chunks +48 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kwiberg-webrtc
Looks fine to me, but the bots say that the deps still aren't quite right...
3 years, 9 months ago (2017-02-28 12:25:46 UTC) #3
kjellander_webrtc
Now it should be fixed. Argh those iOS bots are so flaky these days...
3 years, 9 months ago (2017-02-28 22:34:34 UTC) #4
kwiberg-webrtc
lgtm
3 years, 9 months ago (2017-03-01 10:13:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2719743002/20001
3 years, 9 months ago (2017-03-01 15:05:15 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 15:07:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/50550e1440f28e45d443a0563...

Powered by Google App Engine
This is Rietveld 408576698