Enable GN check for webrtc/common_audio

webrtc/common_audio/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/arm.gni")
 import("../webrtc.gni")
@@ skipping 28 matching lines @@
     "real_fourier.h",
     "real_fourier_ooura.cc",
     "real_fourier_ooura.h",
     "resampler/include/push_resampler.h",
     "resampler/include/resampler.h",
     "resampler/push_resampler.cc",
     "resampler/push_sinc_resampler.cc",
     "resampler/push_sinc_resampler.h",
     "resampler/resampler.cc",
     "resampler/sinc_resampler.cc",
-    "resampler/sinc_resampler.h",
     "smoothing_filter.cc",
     "smoothing_filter.h",
     "sparse_fir_filter.cc",
     "sparse_fir_filter.h",
     "vad/include/vad.h",
     "vad/vad.cc",
     "wav_file.cc",
     "wav_file.h",
     "wav_header.cc",
     "wav_header.h",
     "window_generator.cc",
     "window_generator.h",
   ]
 
   deps = [
+    ":sinc_resampler",
+    "..:webrtc_common",
+    "../base:gtest_prod",
+    "../base:rtc_base_approved",
     "../system_wrappers",
   ]
   public_deps = [
     ":common_audio_c",
   ]
 
   defines = []
   if (rtc_use_openmax_dl) {
     sources += [
       "real_fourier_openmax.cc",
@@ skipping 117 matching lines @@
       "signal_processing/filter_ar_fast_q12.c",
       "signal_processing/spl_sqrt_floor.c",
     ]
   }
 
   if (is_win) {
     cflags = [ "/wd4334" ]  # Ignore warning on shift operator promotion.
   }
 
   public_configs = [ ":common_audio_config" ]
+  deps = [
+    "..:webrtc_common",
+    "../base:rtc_base_approved",
+    "../system_wrappers:system_wrappers",
+  ]
+}
+
+rtc_source_set("sinc_resampler") {
+  sources = [
+    "resampler/sinc_resampler.h",
+  ]
+  deps = [
+    "..:webrtc_common",
+    "../base:gtest_prod",
+    "../base:rtc_base_approved",
+    "../system_wrappers",
+  ]
 }
 
 if (current_cpu == "x86" || current_cpu == "x64") {
   rtc_static_library("common_audio_sse2") {
+    # TODO(kjellander): Remove (bugs.webrtc.org/6828)
+    # Enabling GN check triggers dependency cycle:
+    #   //webrtc/common_audio:common_audio ->
+    #   //webrtc/common_audio:common_audio_sse2 ->
+    #   //webrtc/common_audio:common_audio
+    check_includes = false
     sources = [
       "fir_filter_sse.cc",
       "resampler/sinc_resampler_sse.cc",
     ]
 
     if (is_posix) {
       cflags = [ "-msse2" ]
     }
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
+    deps = [
+      ":sinc_resampler",
+    ]
   }
 }
 
 if (rtc_build_with_neon) {
   rtc_static_library("common_audio_neon") {
+    # TODO(kjellander): Remove (bugs.webrtc.org/6828)
+    # Enabling GN check triggers dependency cycle:
+    #   //webrtc/common_audio:common_audio ->
+    #   //webrtc/common_audio:common_audio_neon ->
+    #   //webrtc/common_audio:common_audio
+    check_includes = false
     sources = [
       "fir_filter_neon.cc",
       "resampler/sinc_resampler_neon.cc",
     ]
 
     if (current_cpu != "arm64") {
       # Enable compilation for the NEON instruction set. This is needed
       # since //build/config/arm.gni only enables NEON for iOS, not Android.
       # This provides the same functionality as webrtc/build/arm_neon.gypi.
       suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ]
       cflags = [ "-mfpu=neon" ]
     }
 
     # Disable LTO on NEON targets due to compiler bug.
     # TODO(fdegans): Enable this. See crbug.com/408997.
     if (rtc_use_lto) {
       cflags -= [
         "-flto",
         "-ffat-lto-objects",
       ]
     }
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
 
+    deps = [
+      ":sinc_resampler",
+    ]
+
     public_deps = [
       ":common_audio_neon_c",
     ]
   }
 
   rtc_source_set("common_audio_neon_c") {
     visibility = [ ":*" ]  # Only targets in this file can depend on this.
     sources = [
       "signal_processing/cross_correlation_neon.c",
       "signal_processing/downsample_fast_neon.c",
@@ skipping 14 matching lines @@
       cflags -= [
         "-flto",
         "-ffat-lto-objects",
       ]
     }
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
+    deps = [
+      ":common_audio_c",
+      "../base:rtc_base_approved",
+    ]
   }
 }
 
 if (rtc_include_tests) {
   rtc_test("common_audio_unittests") {
     testonly = true
 
     sources = [
       "audio_converter_unittest.cc",
       "audio_ring_buffer_unittest.cc",
@@ skipping 33 matching lines @@
       defines = [ "RTC_USE_OPENMAX_DL" ]
     }
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
 
     deps = [
       ":common_audio",
+      ":sinc_resampler",
+      "..:webrtc_common",
+      "../base:rtc_base_approved",
+      "../system_wrappers",
       "../test:test_main",
       "//testing/gmock",
       "//testing/gtest",
     ]
 
     if (is_android) {
       deps += [ "//testing/android/native_test:native_test_support" ]
 
       shard_timeout = 900
     }
   }
 }