Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2718143002: Enable include check for webrtc_h264 target (Closed)

Created:
3 years, 9 months ago by magjed_webrtc
Modified:
3 years, 9 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable include check for webrtc_h264 target BUG=webrtc:7242, webrtc:6828 Review-Url: https://codereview.webrtc.org/2718143002 Cr-Commit-Position: refs/heads/master@{#16888} Committed: https://chromium.googlesource.com/external/webrtc/+/21d110fe4e7ba6fd48f40310e19be5b990cc8e7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M webrtc/modules/video_coding/BUILD.gn View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
magjed_webrtc
kjellander@ - please take a look.
3 years, 9 months ago (2017-02-27 18:38:58 UTC) #5
kjellander_webrtc
I cannot explain why I got different cycle before, but this obviously works, which is ...
3 years, 9 months ago (2017-02-27 20:45:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2718143002/1
3 years, 9 months ago (2017-02-28 08:25:53 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 08:28:10 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/21d110fe4e7ba6fd48f40310e...

Powered by Google App Engine
This is Rietveld 408576698