Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: webrtc/modules/video_coding/BUILD.gn

Issue 2718143002: Enable include check for webrtc_h264 target (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/BUILD.gn
diff --git a/webrtc/modules/video_coding/BUILD.gn b/webrtc/modules/video_coding/BUILD.gn
index 6399ebdf6b403b92d416f4b41d473a5942aa43ab..643260a94638b58977e5b7213c081f241bb99cd3 100644
--- a/webrtc/modules/video_coding/BUILD.gn
+++ b/webrtc/modules/video_coding/BUILD.gn
@@ -143,16 +143,6 @@ rtc_static_library("video_coding_utility") {
}
rtc_static_library("webrtc_h264") {
- # TODO(ehmaldonado): Remove (bugs.webrtc.org/6828)
- # Errors on cyclic dependency if enabled:
- # //webrtc/call:call ->
- # //webrtc/video:video ->
- # //webrtc/modules/video_coding:video_coding ->
- # //webrtc/modules/video_coding:webrtc_h264 ->
- # //webrtc/media:rtc_media ->
- # //webrtc/call:call
- check_includes = false
-
sources = [
"codecs/h264/h264.cc",
"codecs/h264/include/h264.h",
@@ -167,6 +157,7 @@ rtc_static_library("webrtc_h264") {
deps = [
":video_coding_utility",
"../../base:rtc_base_approved",
+ "../../media:rtc_media_base",
"../../system_wrappers",
]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698