Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2718083003: Revert of Move fake_audio_device to its own target. (Closed)

Created:
3 years, 9 months ago by perkj_webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Move fake_audio_device to its own target. (patchset #5 id:80001 of https://codereview.webrtc.org/2717983003/ ) Reason for revert: Breaks build DEPS. Original issue's description: > Move fake_audio_device to its own target. > The purpose is to make it usefull for test targets that does not need or can use test_common. > > For some reason this also triggered override issues in rtp module tests that are fixed in the same cl. > > BUG=none > > Review-Url: https://codereview.webrtc.org/2717983003 > Cr-Commit-Position: refs/heads/master@{#16889} > Committed: https://chromium.googlesource.com/external/webrtc/+/03d850ddf933e6109caa4d716f0dc69ad78d1014 TBR=ehmaldonado@webrtc.org,danilchap@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.webrtc.org/2718083003 Cr-Commit-Position: refs/heads/master@{#16890} Committed: https://chromium.googlesource.com/external/webrtc/+/985371bda999c6db51286586c5850d2ff58f3511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -24 lines) Patch
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/BUILD.gn View 3 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
perkj_webrtc
Created Revert of Move fake_audio_device to its own target.
3 years, 9 months ago (2017-02-28 08:56:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2718083003/1
3 years, 9 months ago (2017-02-28 08:56:23 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 08:56:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/985371bda999c6db51286586c...

Powered by Google App Engine
This is Rietveld 408576698