Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2717983003:
Move fake_audio_device to its own target. (Closed)
|
Created:
3 years, 9 months ago by perkj_webrtc Modified:
3 years, 9 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionMove fake_audio_device to its own target.
The purpose is to make it usefull for test targets that does not need or can use test_common.
For some reason this also triggered override issues in rtp module tests that are fixed in the same cl.
BUG=none
Review-Url: https://codereview.webrtc.org/2717983003
Cr-Commit-Position: refs/heads/master@{#16889}
Committed: https://chromium.googlesource.com/external/webrtc/+/03d850ddf933e6109caa4d716f0dc69ad78d1014
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : rebased #Patch Set 4 : Fix const in argument list of rtp tests. #Patch Set 5 : Fix more rtp.. #
Total comments: 2
Messages
Total messages: 38 (28 generated)
The CQ bit was checked by perkj@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...) ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/17818) mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/19292)
The CQ bit was checked by perkj@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
perkj@webrtc.org changed reviewers: + ehmaldonado@webrtc.org
Please?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_x64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/23159)
The CQ bit was checked by perkj@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/23738) win_x64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/23167)
The CQ bit was checked by perkj@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
perkj@webrtc.org changed reviewers: + danilchap@webrtc.org
Adding danil for rtp test modifications.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_x64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/23177)
The CQ bit was checked by perkj@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
perkj@webrtc.org changed reviewers: + kjellander@webrtc.org
Adding kjellander@ as test owner.
Description was changed from ========== Move fake_audio_device to its own target. The purpose is to make it usefull for test targets that does not need or can use test_common. BUG=none ========== to ========== Move fake_audio_device to its own target. The purpose is to make it usefull for test targets that does not need or can use test_common. For some reason this also triggered override issues in rtp module tests that are fixed in the same cl. BUG=none ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with a question https://codereview.webrtc.org/2717983003/diff/80001/webrtc/test/BUILD.gn File webrtc/test/BUILD.gn (left): https://codereview.webrtc.org/2717983003/diff/80001/webrtc/test/BUILD.gn#oldc... webrtc/test/BUILD.gn:388: "../modules/audio_device:mock_audio_device", Was this unused?
https://codereview.webrtc.org/2717983003/diff/80001/webrtc/test/BUILD.gn File webrtc/test/BUILD.gn (left): https://codereview.webrtc.org/2717983003/diff/80001/webrtc/test/BUILD.gn#oldc... webrtc/test/BUILD.gn:388: "../modules/audio_device:mock_audio_device", On 2017/02/27 20:51:45, kjellander_webrtc wrote: > Was this unused? It used the fake_audio_device that seem like it can either directly depend on audio_device or mock_audio_device.
The CQ bit was checked by perkj@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org Link to the patchset: https://codereview.webrtc.org/2717983003/#ps80001 (title: "Fix more rtp..")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488271683164640,
"parent_rev": "21d110fe4e7ba6fd48f40310e19be5b990cc8e7a", "commit_rev":
"03d850ddf933e6109caa4d716f0dc69ad78d1014"}
Message was sent while issue was closed.
Description was changed from ========== Move fake_audio_device to its own target. The purpose is to make it usefull for test targets that does not need or can use test_common. For some reason this also triggered override issues in rtp module tests that are fixed in the same cl. BUG=none ========== to ========== Move fake_audio_device to its own target. The purpose is to make it usefull for test targets that does not need or can use test_common. For some reason this also triggered override issues in rtp module tests that are fixed in the same cl. BUG=none Review-Url: https://codereview.webrtc.org/2717983003 Cr-Commit-Position: refs/heads/master@{#16889} Committed: https://chromium.googlesource.com/external/webrtc/+/03d850ddf933e6109caa4d716... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/external/webrtc/+/03d850ddf933e6109caa4d716...
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.webrtc.org/2718083003/ by perkj@webrtc.org. The reason for reverting is: Breaks build DEPS..
Message was sent while issue was closed.
On 2017/02/28 08:56:18, perkj_webrtc wrote: > A revert of this CL (patchset #5 id:80001) has been created in > https://codereview.webrtc.org/2718083003/ by mailto:perkj@webrtc.org. > > The reason for reverting is: Breaks build DEPS.. Please always provide a link to a failing build in reverts: https://build.chromium.org/p/client.webrtc/builders/Linux64%20Release/builds/... I think you might have been hit by me landing a couple of GN check enabling CLs around the same time as your CL was submitted. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
