Refactor + enable GN check on video_coding_utility

Refactor + enable GN check on video_coding_utility

To avoid the cyclic dependency

BUG=webrtc:6828
NOTRY=True
TBR=magjed@webrtc.org

Review-Url: https://codereview.webrtc.org/2717113002
Cr-Commit-Position: refs/heads/master@{#17116}
Committed: https://chromium.googlesource.com/external/webrtc/+/a8d8aadba8c64fe7832339ef1e8e802d0718fe38

[kjellander_webrtc, 2017-03-08 08:38:47]

kjellander@webrtc.org changed reviewers:
+ stefan@webrtc.org

[kjellander_webrtc, 2017-03-08 08:40:20]

Description was changed from

==========
Refacor + enable GN check on video_coding_utility

To avoid the cyclic dependency

BUG=webrtc:6828
==========

to

==========
Refacor + enable GN check on video_coding_utility

To avoid the cyclic dependency

BUG=webrtc:6828
==========

[kjellander_webrtc, 2017-03-08 08:40:20]

kjellander@webrtc.org changed reviewers:
+ brandtr@webrtc.org
- stefan@webrtc.org

[kjellander_webrtc, 2017-03-08 08:40:40]

What do you think about this?

[kjellander_webrtc, 2017-03-08 08:41:03]

Description was changed from

==========
Refacor + enable GN check on video_coding_utility

To avoid the cyclic dependency

BUG=webrtc:6828
==========

to

==========
Refactor + enable GN check on video_coding_utility

To avoid the cyclic dependency

BUG=webrtc:6828
==========

[kjellander_webrtc, 2017-03-08 09:22:18]

Description was changed from

==========
Refactor + enable GN check on video_coding_utility

To avoid the cyclic dependency

BUG=webrtc:6828
==========

to

==========
Refactor + enable GN check on video_coding_utility

To avoid the cyclic dependency

BUG=webrtc:6828
NOTRY=True
==========

[brandtr, 2017-03-08 10:37:14]

lgtm.

Does it make sense to move these files now? (Could be done in a followup CL.) I
don't know if we usually try to have targets map to directories?

https://codereview.webrtc.org/2717113002/diff/1/webrtc/modules/video_coding/B...
File webrtc/modules/video_coding/BUILD.gn (right):

https://codereview.webrtc.org/2717113002/diff/1/webrtc/modules/video_coding/B...
webrtc/modules/video_coding/BUILD.gn:74: "utility/qp_parser.cc",
Move to ..?

https://codereview.webrtc.org/2717113002/diff/1/webrtc/modules/video_coding/B...
webrtc/modules/video_coding/BUILD.gn:224: "utility/simulcast_rate_allocator.cc",
Move to codecs/vp8?

[kjellander_webrtc, 2017-03-08 11:15:32]

Patchset #2 (id:20001) has been deleted

[kjellander_webrtc, 2017-03-08 11:16:18]

Did the refactoring. Will land after running Chromium trybots

https://codereview.webrtc.org/2717113002/diff/1/webrtc/modules/video_coding/B...
File webrtc/modules/video_coding/BUILD.gn (right):

https://codereview.webrtc.org/2717113002/diff/1/webrtc/modules/video_coding/B...
webrtc/modules/video_coding/BUILD.gn:74: "utility/qp_parser.cc",
On 2017/03/08 10:37:14, brandtr wrote:
> Move to ..?

Done.

https://codereview.webrtc.org/2717113002/diff/1/webrtc/modules/video_coding/B...
webrtc/modules/video_coding/BUILD.gn:224: "utility/simulcast_rate_allocator.cc",
On 2017/03/08 10:37:14, brandtr wrote:
> Move to codecs/vp8?

Done.

[kjellander_webrtc, 2017-03-08 11:52:45]

kjellander@webrtc.org changed reviewers:
+ magjed@webrtc.org

[kjellander_webrtc, 2017-03-08 11:52:46]

+magjed for webrtc/media/engine/videoencodersoftwarefallbackwrapper_unittest.cc

[kjellander_webrtc, 2017-03-08 13:36:28]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2017-03-08 13:36:28]

The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2717113002/#ps40001 (title:
"Moved the source files as well")

[kjellander_webrtc, 2017-03-08 13:36:37]

Description was changed from

==========
Refactor + enable GN check on video_coding_utility

To avoid the cyclic dependency

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Refactor + enable GN check on video_coding_utility

To avoid the cyclic dependency

BUG=webrtc:6828
NOTRY=True
TBR=magjed@webrtc.org
==========

[commit-bot: I haz the power, 2017-03-08 13:36:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-08 13:38:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 13:38:57]

Failed to apply patch for webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:
While running git apply --index -p1;
  error: patch failed: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:28
  error: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc: patch does not
apply

Patch:       webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
Index: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
index
89752a9b824a26414acdb384a7199ed5688ccef2..ce0a9b9f940b09501b6f0e3bd95023e7adbb75e2
100644
--- a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
+++ b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
@@ -28,8 +28,8 @@
 #include "webrtc/modules/video_coding/include/video_codec_interface.h"
 #include "webrtc/modules/video_coding/codecs/vp8/include/vp8_common_types.h"
 #include "webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h"
+#include "webrtc/modules/video_coding/codecs/vp8/simulcast_rate_allocator.h"
 #include "webrtc/modules/video_coding/codecs/vp8/temporal_layers.h"
-#include "webrtc/modules/video_coding/utility/simulcast_rate_allocator.h"
 #include "webrtc/system_wrappers/include/clock.h"
 #include "webrtc/system_wrappers/include/metrics.h"

[kjellander_webrtc, 2017-03-08 13:40:06]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2017-03-08 13:40:07]

The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2717113002/#ps60001 (title:
"Rebased")

[commit-bot: I haz the power, 2017-03-08 13:40:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-08 13:42:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488980406788110,
"parent_rev": "e9369a951db4c4bab37ea68858b89ddb9276d02a", "commit_rev":
"a8d8aadba8c64fe7832339ef1e8e802d0718fe38"}

[commit-bot: I haz the power, 2017-03-08 13:42:29]

Description was changed from

==========
Refactor + enable GN check on video_coding_utility

To avoid the cyclic dependency

BUG=webrtc:6828
NOTRY=True
TBR=magjed@webrtc.org
==========

to

==========
Refactor + enable GN check on video_coding_utility

To avoid the cyclic dependency

BUG=webrtc:6828
NOTRY=True
TBR=magjed@webrtc.org

Review-Url: https://codereview.webrtc.org/2717113002
Cr-Commit-Position: refs/heads/master@{#17116}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a8d8aadba8c64fe7832339ef1...
==========

[commit-bot: I haz the power, 2017-03-08 13:42:30]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/a8d8aadba8c64fe7832339ef1...