Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2716733007: cc: Rename LayerImpl::render_surface to GetRenderSurface (Closed)

Created:
3 years, 10 months ago by ajuma
Modified:
3 years, 10 months ago
Reviewers:
jaydasika, weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Rename LayerImpl::render_surface to GetRenderSurface This renames LayerImpl::render_surface since it is no longer a trivial getter. This also deletes LayerImpl::has_render_surface (which was just calling render_surface()) and changes callsites to directly use GetRenderSurface() instead. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2716733007 Cr-Commit-Position: refs/heads/master@{#452977} Committed: https://chromium.googlesource.com/chromium/src/+/ac2d30797f91fe7927a0b632c418ec6ef616be4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+639 lines, -613 lines) Patch
M cc/debug/debug_rect_history.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M cc/layers/layer_impl.h View 2 chunks +1 line, -4 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_iterator.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/layer_iterator_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/layer_position_constraint_unittest.cc View 8 chunks +24 lines, -24 lines 0 comments Download
M cc/layers/render_surface_impl_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/layers/render_surface_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/damage_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 69 chunks +169 lines, -155 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 98 chunks +335 lines, -329 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 5 chunks +20 lines, -19 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_damage.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_occlusion.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_video.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 18 chunks +29 lines, -29 lines 0 comments Download
M cc/trees/occlusion_tracker.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
ajuma
3 years, 10 months ago (2017-02-24 21:34:37 UTC) #10
weiliangc
lgtm
3 years, 10 months ago (2017-02-24 22:53:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716733007/1
3 years, 10 months ago (2017-02-24 22:54:47 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 23:01:13 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac2d30797f91fe7927a0b632c418...

Powered by Google App Engine
This is Rietveld 408576698