Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2716703004: Reland of Add metal view, shaders and renderer. (Closed)

Created:
3 years, 10 months ago by daniela-webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add metal view, shaders and renderer. (patchset #1 id:1 of https://codereview.webrtc.org/2711003004/ ) Reason for revert: Re-land Original issue's description: > Revert of Add metal view, shaders and renderer. (patchset #18 id:340001 of https://codereview.webrtc.org/2651743007/ ) > > Reason for revert: > Reverting due to breakage in the Google3 import > > Original issue's description: > > Add metal view, shaders and renderer. > > > > This CL submits standalone Metal view, renderer and shader. > > > > BUG=webrtc:7079 > > > > Review-Url: https://codereview.webrtc.org/2651743007 > > Cr-Commit-Position: refs/heads/master@{#16787} > > Committed: https://chromium.googlesource.com/external/webrtc/+/fc8c97f950a4fead4a5debe3c838942db1834010 > > TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7079 > > Review-Url: https://codereview.webrtc.org/2711003004 > Cr-Commit-Position: refs/heads/master@{#16788} > Committed: https://chromium.googlesource.com/external/webrtc/+/b681aabdfcdcb22de049df3916f2dd8c40dcbf57 TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2716703004 Cr-Commit-Position: refs/heads/master@{#16846} Committed: https://chromium.googlesource.com/external/webrtc/+/070d5e30a8fa9fa36f5dbe18c0ea912b5dd6b14d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+511 lines, -0 lines) Patch
M webrtc/sdk/BUILD.gn View 2 chunks +16 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLNV12Renderer.h View 1 chunk +41 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLNV12Renderer.mm View 1 chunk +319 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLVideoView.m View 1 chunk +107 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLVideoView.h View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
daniela-webrtc
Created Reland of Add metal view, shaders and renderer.
3 years, 10 months ago (2017-02-24 14:46:41 UTC) #1
tkchin_webrtc
On 2017/02/24 14:46:41, denicija-webrtc wrote: > Created Reland of Add metal view, shaders and renderer. ...
3 years, 10 months ago (2017-02-24 18:14:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2716703004/1
3 years, 9 months ago (2017-02-26 18:20:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_memcheck on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/5706)
3 years, 9 months ago (2017-02-26 18:56:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2716703004/1
3 years, 9 months ago (2017-02-26 19:41:37 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-02-26 19:44:18 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/070d5e30a8fa9fa36f5dbe18c...

Powered by Google App Engine
This is Rietveld 408576698