Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Issue 2711003004: Revert of Add metal view, shaders and renderer. (Closed)

Created:
3 years, 10 months ago by daniela-webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add metal view, shaders and renderer. (patchset #18 id:340001 of https://codereview.webrtc.org/2651743007/ ) Reason for revert: Reverting due to breakage in the Google3 import Original issue's description: > Add metal view, shaders and renderer. > > This CL submits standalone Metal view, renderer and shader. > > BUG=webrtc:7079 > > Review-Url: https://codereview.webrtc.org/2651743007 > Cr-Commit-Position: refs/heads/master@{#16787} > Committed: https://chromium.googlesource.com/external/webrtc/+/fc8c97f950a4fead4a5debe3c838942db1834010 TBR=magjed@webrtc.org,kthelgason@webrtc.org,tkchin@webrtc.org,haysc@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2711003004 Cr-Commit-Position: refs/heads/master@{#16788} Committed: https://chromium.googlesource.com/external/webrtc/+/b681aabdfcdcb22de049df3916f2dd8c40dcbf57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -511 lines) Patch
M webrtc/sdk/BUILD.gn View 2 chunks +0 lines, -16 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLNV12Renderer.h View 1 chunk +0 lines, -41 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLNV12Renderer.mm View 1 chunk +0 lines, -319 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLVideoView.m View 1 chunk +0 lines, -107 lines 0 comments Download
D webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMTLVideoView.h View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
daniela-webrtc
Created Revert of Add metal view, shaders and renderer.
3 years, 10 months ago (2017-02-23 09:14:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2711003004/1
3 years, 10 months ago (2017-02-23 09:14:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/b681aabdfcdcb22de049df3916f2dd8c40dcbf57
3 years, 10 months ago (2017-02-23 09:15:13 UTC) #6
daniela-webrtc
3 years, 10 months ago (2017-02-24 14:46:41 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2716703004/ by denicija@webrtc.org.

The reason for reverting is: Re-land.

Powered by Google App Engine
This is Rietveld 408576698