Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1513)

Issue 2715133002: Remove extra call to TimeUntilNextProcess from within Process. (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove extra call to TimeUntilNextProcess from within Process. I noticed while profiling calls to TimeUntilNextProcess. It's benign, but the implementation seems to be done to accomodate the test rather than the other way around, so I'm making the test behave more like a ProcessThread would. BUG=None Review-Url: https://codereview.webrtc.org/2715133002 Cr-Commit-Position: refs/heads/master@{#16867} Committed: https://chromium.googlesource.com/external/webrtc/+/ea5f06f7e6b317debb3030fd3b73ca5926eec0dd

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 3 chunks +5 lines, -8 lines 2 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
tommi
3 years, 9 months ago (2017-02-26 17:43:47 UTC) #2
tommi
bjorn - since stefan is out, can you take a look?
3 years, 9 months ago (2017-02-27 12:45:38 UTC) #8
terelius
lgtm https://codereview.webrtc.org/2715133002/diff/1/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc File webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc (left): https://codereview.webrtc.org/2715133002/diff/1/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc#oldcode148 webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc:148: } So we can rely on the ProcessThread ...
3 years, 9 months ago (2017-02-27 13:13:14 UTC) #9
tommi
https://codereview.webrtc.org/2715133002/diff/1/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc File webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc (left): https://codereview.webrtc.org/2715133002/diff/1/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc#oldcode148 webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc:148: } On 2017/02/27 13:13:14, terelius wrote: > So we ...
3 years, 9 months ago (2017-02-27 13:39:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2715133002/1
3 years, 9 months ago (2017-02-27 13:39:09 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 13:41:27 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/ea5f06f7e6b317debb3030fd3...

Powered by Google App Engine
This is Rietveld 408576698