webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc - Issue 2715133002: Remove extra call to TimeUntilNextProcess from within Process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc

Issue 2715133002: Remove extra call to TimeUntilNextProcess from within Process. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc ('K') | « webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc

index b77550f12120ef55a3309c9f0e71d4c3542440a3..fef4d8dfb2f3d42f47b1d7d78c95a1021a8441e5 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc

+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc

@@ -270,7 +270,8 @@ bool RemoteBitrateEstimatorTest::GenerateAndProcessFrame(uint32_t ssrc,

delete packet;

packets.pop_front();

}

- bitrate_estimator_->Process();

+ if (bitrate_estimator_->TimeUntilNextProcess() <= 0)

+ bitrate_estimator_->Process();

clock_.AdvanceTimeMicroseconds(next_time_us - clock_.TimeInMicroseconds());

return overuse;

}