Introduce dchecked_cast, and start using it

Introduce dchecked_cast, and start using it

It's the faster, less strict cousin of checked_cast.

BUG=none

Review-Url: https://codereview.webrtc.org/2714063002
Cr-Commit-Position: refs/heads/master@{#16958}
Committed: https://chromium.googlesource.com/external/webrtc/+/d3edd770ade4a9323e136a39737957963cc676b7

[kwiberg-webrtc, 2017-02-24 02:13:57]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 02:14:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-02-24 02:31:54]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, ossu@webrtc.org

[kwiberg-webrtc, 2017-02-24 02:31:55]

I thought it would be involved to create dchecked_cast, but it was so trivial I
just had to do it right away!

[commit-bot: I haz the power, 2017-02-24 02:33:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 02:33:18]

Dry run: Try jobs failed on following builders:
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/20159)

[hlundin-webrtc, 2017-02-24 07:55:09]

lgtm

[ossu, 2017-03-02 00:54:14]

lgtm

https://codereview.webrtc.org/2714063002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_impl.cc (right):

https://codereview.webrtc.org/2714063002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_impl.cc:1501: *decoded_length +=
rtc::dchecked_cast<int>(result.num_decoded_samples);
These decoded_length checks (above and below as well) seem scary to me, but not
in a way that a checked_cast would solve, so I guess dchecked_cast is just as
useful.

[kwiberg-webrtc, 2017-03-02 02:13:37]

https://codereview.webrtc.org/2714063002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_impl.cc (right):

https://codereview.webrtc.org/2714063002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_impl.cc:1501: *decoded_length +=
rtc::dchecked_cast<int>(result.num_decoded_samples);
On 2017/03/02 00:54:14, ossu wrote:
> These decoded_length checks (above and below as well) seem scary to me, but
not
> in a way that a checked_cast would solve, so I guess dchecked_cast is just as
> useful.

Acknowledged.

[kwiberg-webrtc, 2017-03-02 02:13:45]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-03-02 02:13:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-02 02:52:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488420825357390, "parent_rev":
"3126ef5416f1fa4760e248cccae4589ed4859c30", "commit_rev":
"d3edd770ade4a9323e136a39737957963cc676b7"}

[commit-bot: I haz the power, 2017-03-02 02:52:52]

Description was changed from

==========
Introduce dchecked_cast, and start using it

It's the faster, less strict cousin of checked_cast.

BUG=none
==========

to

==========
Introduce dchecked_cast, and start using it

It's the faster, less strict cousin of checked_cast.

BUG=none

Review-Url: https://codereview.webrtc.org/2714063002
Cr-Commit-Position: refs/heads/master@{#16958}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d3edd770ade4a9323e136a397...
==========

[commit-bot: I haz the power, 2017-03-02 02:52:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d3edd770ade4a9323e136a397...