webrtc/modules/audio_coding/neteq/time_stretch.cc - Issue 2714063002: Introduce dchecked_cast, and start using it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/time_stretch.cc

Issue 2714063002: Introduce dchecked_cast, and start using it (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/neteq/time_stretch.cc

diff --git a/webrtc/modules/audio_coding/neteq/time_stretch.cc b/webrtc/modules/audio_coding/neteq/time_stretch.cc

index 880b1f82ea595271ee0f92795f8a39542e5039f4..28feadcb5c46dd4162e3743082ab012d8199f434 100644

--- a/webrtc/modules/audio_coding/neteq/time_stretch.cc

+++ b/webrtc/modules/audio_coding/neteq/time_stretch.cc

@@ -194,7 +194,7 @@ bool TimeStretch::SpeechDetection(int32_t vec1_energy, int32_t vec2_energy,

right_scale = std::max(0, right_scale);

left_side = left_side >> right_scale;

right_side =

- rtc::checked_cast<int32_t>(peak_index) * (right_side >> right_scale);

+ rtc::dchecked_cast<int32_t>(peak_index) * (right_side >> right_scale);

// Scale |left_side| properly before comparing with |right_side|.

// (|scaling| is the scale factor before energy calculation, thus the scale