Move FrameSink hierarchy registration to DisplayCompositor interface

Move FrameSink hierarchy registration to DisplayCompositor interface

Previously, SurfaceManager tied FrameSink hierarchy registration with 
validity of FrameSinkIds. This expectation has been removed. Thus, we 
can now register the entire ServerWindow tree with the display 
compositor. This greatly simplifies window reparenting and addresses 
correctness issues for reparenting across monitors.

BUG=653895
TBR=jbauman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2711913006
Cr-Commit-Position: refs/heads/master@{#452989}
Committed: https://chromium.googlesource.com/chromium/src/+/60b01374443cd1e14598ed8fd554109c697a096f

[Fady Samuel, 2017-02-24 19:39:24]

Description was changed from

==========
Move FrameSink hierarchy registration to DisplayCompositor interface

Previously, SurfaceManager required tied FrameSink hierarchy
registration with validity of FrameSinkIds. This expectation has been
removed. Thus, we can now register the entire ServerWindow tree with
the display compositor. This greatly simplifies window reparenting
and addresses correctness issues for reparenting across monitors.

BUG=653895
==========

to

==========
Move FrameSink hierarchy registration to DisplayCompositor interface

Previously, SurfaceManager required tied FrameSink hierarchy
registration with validity of FrameSinkIds. This expectation has been
removed. Thus, we can now register the entire ServerWindow tree with
the display compositor. This greatly simplifies window reparenting
and addresses correctness issues for reparenting across monitors.

BUG=653895
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2017-02-24 19:44:52]

fsamuel@chromium.org changed reviewers:
+ jbauman@chromium.org, sky@chromium.org, tsepez@chromium.org

[Fady Samuel, 2017-02-24 19:44:53]

+tsepez@ for ipc
+jbauman@ for cc/surfaces and components/display_compositor
+sky@ for services/ui/

[Fady Samuel, 2017-02-24 19:45:36]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 19:46:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-02-24 19:50:00]

Description was changed from

==========
Move FrameSink hierarchy registration to DisplayCompositor interface

Previously, SurfaceManager required tied FrameSink hierarchy
registration with validity of FrameSinkIds. This expectation has been
removed. Thus, we can now register the entire ServerWindow tree with
the display compositor. This greatly simplifies window reparenting
and addresses correctness issues for reparenting across monitors.

BUG=653895
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move FrameSink hierarchy registration to DisplayCompositor interface

Previously, SurfaceManager  tied FrameSink hierarchy registration with 
validity of FrameSinkIds. This expectation has been removed. Thus, we 
can now register the entire ServerWindow tree with the display 
compositor. This greatly simplifies window reparenting and addresses 
correctness issues for reparenting across monitors.

BUG=653895
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2017-02-24 20:00:24]

fsamuel@chromium.org changed reviewers:
+ enne@chromium.org

[Fady Samuel, 2017-02-24 20:00:24]

+enne@ FYI

Based on what we discussed. SurfaceManager is now made aware of all
ServerWindows (all FrameSinkIds), even ones that don't have corresponding
CompositorFrameSinks.

[Fady Samuel, 2017-02-24 20:29:05]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 20:29:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-02-24 20:39:37]

lgtm

[sky, 2017-02-24 21:04:09]

LGTM

[enne (OOO), 2017-02-24 21:10:55]

approach to move registration to the display compositor lgtm

[kylechar, 2017-02-24 21:23:16]

https://codereview.chromium.org/2711913006/diff/40001/cc/ipc/display_composit...
File cc/ipc/display_compositor.mojom (right):

https://codereview.chromium.org/2711913006/diff/40001/cc/ipc/display_composit...
cc/ipc/display_compositor.mojom:65: cc.mojom.FrameSinkId child_frame_sink_id);
formatting.

https://codereview.chromium.org/2711913006/diff/40001/cc/ipc/display_composit...
cc/ipc/display_compositor.mojom:69: cc.mojom.FrameSinkId child_frame_sink_id);
formatting.

[Fady Samuel, 2017-02-24 21:34:36]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2017-02-24 21:34:47]

PTAL John!

https://codereview.chromium.org/2711913006/diff/40001/cc/ipc/display_composit...
File cc/ipc/display_compositor.mojom (right):

https://codereview.chromium.org/2711913006/diff/40001/cc/ipc/display_composit...
cc/ipc/display_compositor.mojom:65: cc.mojom.FrameSinkId child_frame_sink_id);
On 2017/02/24 21:23:16, kylechar wrote:
> formatting.

Done.

https://codereview.chromium.org/2711913006/diff/40001/cc/ipc/display_composit...
cc/ipc/display_compositor.mojom:69: cc.mojom.FrameSinkId child_frame_sink_id);
On 2017/02/24 21:23:16, kylechar wrote:
> formatting.

Done.

[Fady Samuel, 2017-02-24 21:34:47]

PTAL John!

https://codereview.chromium.org/2711913006/diff/40001/cc/ipc/display_composit...
File cc/ipc/display_compositor.mojom (right):

https://codereview.chromium.org/2711913006/diff/40001/cc/ipc/display_composit...
cc/ipc/display_compositor.mojom:65: cc.mojom.FrameSinkId child_frame_sink_id);
On 2017/02/24 21:23:16, kylechar wrote:
> formatting.

Done.

https://codereview.chromium.org/2711913006/diff/40001/cc/ipc/display_composit...
cc/ipc/display_compositor.mojom:69: cc.mojom.FrameSinkId child_frame_sink_id);
On 2017/02/24 21:23:16, kylechar wrote:
> formatting.

Done.

[commit-bot: I haz the power, 2017-02-24 21:35:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-02-24 21:37:27]

I'm TBR'ing jbauman@ since components/display_compositor changes are all code
deletion.

[Fady Samuel, 2017-02-24 21:37:44]

Description was changed from

==========
Move FrameSink hierarchy registration to DisplayCompositor interface

Previously, SurfaceManager  tied FrameSink hierarchy registration with 
validity of FrameSinkIds. This expectation has been removed. Thus, we 
can now register the entire ServerWindow tree with the display 
compositor. This greatly simplifies window reparenting and addresses 
correctness issues for reparenting across monitors.

BUG=653895
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move FrameSink hierarchy registration to DisplayCompositor interface

Previously, SurfaceManager  tied FrameSink hierarchy registration with 
validity of FrameSinkIds. This expectation has been removed. Thus, we 
can now register the entire ServerWindow tree with the display 
compositor. This greatly simplifies window reparenting and addresses 
correctness issues for reparenting across monitors.

BUG=653895
TBR=jbauman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2017-02-24 21:38:05]

Description was changed from

==========
Move FrameSink hierarchy registration to DisplayCompositor interface

Previously, SurfaceManager  tied FrameSink hierarchy registration with 
validity of FrameSinkIds. This expectation has been removed. Thus, we 
can now register the entire ServerWindow tree with the display 
compositor. This greatly simplifies window reparenting and addresses 
correctness issues for reparenting across monitors.

BUG=653895
TBR=jbauman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move FrameSink hierarchy registration to DisplayCompositor interface

Previously, SurfaceManager tied FrameSink hierarchy registration with 
validity of FrameSinkIds. This expectation has been removed. Thus, we 
can now register the entire ServerWindow tree with the display 
compositor. This greatly simplifies window reparenting and addresses 
correctness issues for reparenting across monitors.

BUG=653895
TBR=jbauman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2017-02-24 23:08:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 23:08:13]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-02-24 23:14:22]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2017-02-24 23:14:22]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2711913006/#ps60001
(title: "Fix mojom Formatting")

[commit-bot: I haz the power, 2017-02-24 23:14:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 23:21:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487978062469000,
"parent_rev": "fdc4e40323d4c151cd255635396e2af4089b366b", "commit_rev":
"60b01374443cd1e14598ed8fd554109c697a096f"}

[commit-bot: I haz the power, 2017-02-24 23:22:32]

Description was changed from

==========
Move FrameSink hierarchy registration to DisplayCompositor interface

Previously, SurfaceManager tied FrameSink hierarchy registration with 
validity of FrameSinkIds. This expectation has been removed. Thus, we 
can now register the entire ServerWindow tree with the display 
compositor. This greatly simplifies window reparenting and addresses 
correctness issues for reparenting across monitors.

BUG=653895
TBR=jbauman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move FrameSink hierarchy registration to DisplayCompositor interface

Previously, SurfaceManager tied FrameSink hierarchy registration with 
validity of FrameSinkIds. This expectation has been removed. Thus, we 
can now register the entire ServerWindow tree with the display 
compositor. This greatly simplifies window reparenting and addresses 
correctness issues for reparenting across monitors.

BUG=653895
TBR=jbauman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2711913006
Cr-Commit-Position: refs/heads/master@{#452989}
Committed:
https://chromium.googlesource.com/chromium/src/+/60b01374443cd1e14598ed8fd554...
==========

[commit-bot: I haz the power, 2017-02-24 23:22:33]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/60b01374443cd1e14598ed8fd554...