Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: services/ui/surfaces/display_compositor.h

Issue 2711913006: Move FrameSink hierarchy registration to DisplayCompositor interface (Closed)
Patch Set: Fix mojom Formatting Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/surfaces/display_compositor.h
diff --git a/services/ui/surfaces/display_compositor.h b/services/ui/surfaces/display_compositor.h
index a7968969a67cd9bf142bd8b233a91e2aa616af41..fbc8565dabb9b3c8449ec86dfba1f91604a47adb 100644
--- a/services/ui/surfaces/display_compositor.h
+++ b/services/ui/surfaces/display_compositor.h
@@ -62,12 +62,6 @@ class DisplayCompositor
cc::SurfaceManager* manager() { return &manager_; }
- // display_compositor::GpuCompositorFrameSinkDelegate implementation.
- void OnClientConnectionLost(const cc::FrameSinkId& frame_sink_id,
- bool destroy_compositor_frame_sink) override;
- void OnPrivateConnectionLost(const cc::FrameSinkId& frame_sink_id,
- bool destroy_compositor_frame_sink) override;
-
// cc::mojom::DisplayCompositor implementation:
void CreateRootCompositorFrameSink(
const cc::FrameSinkId& frame_sink_id,
@@ -82,6 +76,12 @@ class DisplayCompositor
cc::mojom::MojoCompositorFrameSinkRequest request,
cc::mojom::MojoCompositorFrameSinkPrivateRequest private_request,
cc::mojom::MojoCompositorFrameSinkClientPtr client) override;
+ void RegisterFrameSinkHierarchy(
+ const cc::FrameSinkId& parent_frame_sink_id,
+ const cc::FrameSinkId& child_frame_sink_id) override;
+ void UnregisterFrameSinkHierarchy(
+ const cc::FrameSinkId& parent_frame_sink_id,
+ const cc::FrameSinkId& child_frame_sink_id) override;
private:
std::unique_ptr<cc::Display> CreateDisplay(
@@ -89,16 +89,6 @@ class DisplayCompositor
gpu::SurfaceHandle surface_handle,
cc::SyntheticBeginFrameSource* begin_frame_source);
- void CreateCompositorFrameSinkInternal(
- const cc::FrameSinkId& frame_sink_id,
- gpu::SurfaceHandle surface_handle,
- std::unique_ptr<cc::Display> display,
- std::unique_ptr<cc::SyntheticBeginFrameSource> begin_frame_source,
- cc::mojom::MojoCompositorFrameSinkRequest request,
- cc::mojom::MojoCompositorFrameSinkPrivateRequest private_request,
- cc::mojom::MojoCompositorFrameSinkClientPtr client,
- cc::mojom::DisplayPrivateRequest display_private_request);
-
// It is necessary to pass |frame_sink_id| by value because the id
// is owned by the GpuCompositorFrameSink in the map. When the sink is
// removed from the map, |frame_sink_id| would also be destroyed if it were a
@@ -111,6 +101,12 @@ class DisplayCompositor
void OnSurfaceDamaged(const cc::SurfaceId& surface_id,
bool* changed) override;
+ // display_compositor::GpuCompositorFrameSinkDelegate implementation.
+ void OnClientConnectionLost(const cc::FrameSinkId& frame_sink_id,
+ bool destroy_compositor_frame_sink) override;
+ void OnPrivateConnectionLost(const cc::FrameSinkId& frame_sink_id,
+ bool destroy_compositor_frame_sink) override;
+
// SurfaceManager should be the first object constructed and the last object
// destroyed in order to ensure that all other objects that depend on it have
// access to a valid pointer for the entirety of their liftimes.
« no previous file with comments | « components/display_compositor/gpu_root_compositor_frame_sink.cc ('k') | services/ui/surfaces/display_compositor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698