Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2709733002: Merge to 57: Screen content simulcast layers should not be downscaled. (Closed)

Created:
3 years, 10 months ago by sprang_webrtc
Modified:
3 years, 10 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/branch-heads/57
Project:
webrtc
Visibility:
Public.

Description

Merge to 57: Screen content simulcast layers should not be downscaled. Fix config so, size isn't downscaled, add unit test coverage. BUG=webrtc:7171, webrtc:4172 Original Review-Url: https://codereview.webrtc.org/2692343007 Original Cr-Commit-Position: refs/heads/master@{#16648} R=mflodman@webrtc.org Review-Url: https://codereview.webrtc.org/2709733002 . Cr-Commit-Position: refs/branch-heads/57@{#6} Cr-Branched-From: e5cbc2019003dbb40e03811d7607feb95757a4ec-refs/heads/master@{#16123} Committed: https://chromium.googlesource.com/external/webrtc/+/0a71dc836641acdaaa63b2724f83c822dbb58ce7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M webrtc/media/engine/simulcast.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sprang_webrtc
3 years, 10 months ago (2017-02-21 13:08:18 UTC) #2
mflodman
lgtm
3 years, 10 months ago (2017-02-21 14:09:30 UTC) #3
sprang_webrtc
3 years, 10 months ago (2017-02-21 14:18:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a71dc836641acdaaa63b2724f83c822dbb58ce7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698