Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2692343007: Screen content simulcast layers should not be downscaled. (Closed)

Created:
3 years, 10 months ago by sprang_webrtc
Modified:
3 years, 10 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Screen content simulcast layers should not be downscaled. Fix config so, size isn't downscaled, add unit test coverage. BUG=webrtc:7171, webrtc:4172 Review-Url: https://codereview.webrtc.org/2692343007 Cr-Commit-Position: refs/heads/master@{#16648} Committed: https://chromium.googlesource.com/external/webrtc/+/3ebabf1c2983c99bfea9fe47373920d23dd99f55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M webrtc/media/engine/simulcast.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sprang_webrtc
3 years, 10 months ago (2017-02-16 13:43:30 UTC) #4
mflodman
lgtm
3 years, 10 months ago (2017-02-16 13:51:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2692343007/1
3 years, 10 months ago (2017-02-16 15:32:48 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 15:35:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/3ebabf1c2983c99bfea9fe473...

Powered by Google App Engine
This is Rietveld 408576698