Move rtc_api_unittests into rtc_unittests.

Move rtc_api_unittests into rtc_unittests.

This avoids adding an additional test target. Plus, everything in
rtc_api_unittests is (and likely will be) simple utility classes akin to
what's already being tested in rtc_unittests.

BUG=None
TBR=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2709573003
Cr-Commit-Position: refs/heads/master@{#16819}
Committed: https://chromium.googlesource.com/external/webrtc/+/b5388d77489388e5a9941cca9b979f9cfb4c8f76

[Taylor Brandstetter, 2017-02-21 17:59:43]

Description was changed from

==========
Move rtc_api_unittests into rtc_unittests.

This avoids adding an additional test target. Plus, everything in
rtc_api_unittests is (and likely will be) simple utility classes akin to
what's already being tested in rtc_unittests.

BUG=None
==========

to

==========
Move rtc_api_unittests into rtc_unittests.

This avoids adding an additional test target. Plus, everything in
rtc_api_unittests is (and likely will be) simple utility classes akin to
what's already being tested in rtc_unittests.

BUG=None
TBR=kjellander@webrtc.org
==========

[Taylor Brandstetter, 2017-02-21 17:59:51]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-02-21 17:59:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Taylor Brandstetter, 2017-02-21 18:00:03]

deadbeef@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[commit-bot: I haz the power, 2017-02-21 18:01:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 18:01:50]

Try jobs failed on following builders:
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/17584)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/21806)

[Taylor Brandstetter, 2017-02-21 20:35:37]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-02-21 20:35:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-21 20:38:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 20:38:58]

Try jobs failed on following builders:
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/23036)

[kjellander_webrtc, 2017-02-21 20:58:28]

kjellander@webrtc.org changed reviewers:
+ ehmaldonado@webrtc.org

[kjellander_webrtc, 2017-02-21 20:58:28]

*argh* not again!
Edward and I investigated a similar error in
https://codereview.webrtc.org/2649563002 which had to be reverted after submit.
It appears even clobber builds was not sufficient to solve the problem (even if
it wipes the whole out/ dir).

I think this might be a Goma bug so I've filed
https://bugs.chromium.org/p/chromium/issues/detail?id=694721. I suggest we wait
for that before submitting this, as it's no hurry.

[Taylor Brandstetter, 2017-02-21 23:20:32]

On 2017/02/21 20:58:28, kjellander_webrtc wrote:
> *argh* not again!
> Edward and I investigated a similar error in
> https://codereview.webrtc.org/2649563002 which had to be reverted after
submit.
> It appears even clobber builds was not sufficient to solve the problem (even
if
> it wipes the whole out/ dir).
> 
> I think this might be a Goma bug so I've filed
> https://bugs.chromium.org/p/chromium/issues/detail?id=694721. I suggest we
wait
> for that before submitting this, as it's no hurry.

Something weird is happening on Windows too:

"unknown file: error: SEH exception with code 0xc0000005 thrown in the test
body."

Could it actually be some problem with this CL?

[kjellander_webrtc, 2017-02-22 09:29:31]

On 2017/02/21 23:20:32, Taylor Brandstetter wrote:
> On 2017/02/21 20:58:28, kjellander_webrtc wrote:
> > *argh* not again!
> > Edward and I investigated a similar error in
> > https://codereview.webrtc.org/2649563002 which had to be reverted after
> submit.
> > It appears even clobber builds was not sufficient to solve the problem (even
> if
> > it wipes the whole out/ dir).
> > 
> > I think this might be a Goma bug so I've filed
> > https://bugs.chromium.org/p/chromium/issues/detail?id=694721. I suggest we
> wait
> > for that before submitting this, as it's no hurry.

So, my landmine CL in
https://chromium.googlesource.com/external/webrtc/+/47f0799059607b4663391b656...
solved the iOS issue, *phew*.
Now all we need to do is to get the test passing on Windows, then we can submit
this.

> Something weird is happening on Windows too:
> 
> "unknown file: error: SEH exception with code 0xc0000005 thrown in the test
> body."

No, I think that's just the test is not properly implemented on Windows. See
http://stackoverflow.com/questions/13157671/seh-exception-with-code-0xc000000...

> Could it actually be some problem with this CL?

No, it's probably just an error in the test (which didn't run before this).

[Taylor Brandstetter, 2017-02-23 22:39:35]

Well, the Windows-specific issue was... interesting. Apparently Visual Studio
doesn't support "= default" with move constructors, even though the code
compiles: https://msdn.microsoft.com/en-us/library/hh567368.aspx

So *this* is enough to cause a segfault:

struct Foo {
  Foo(int value) : value(value) {}
  Foo(Foo&& other) = default;
  int value;
};

void Bar(Foo f) {
  LOG(LS_INFO) << f.value;
}

TEST(Crashes, Why) {
  Bar(Foo(1));
}

And if you just comment out the "= default" move constructor, or implement it
explicitly, it works. Weirdest compiler bug I've ever seen.

[Taylor Brandstetter, 2017-02-23 22:41:40]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-02-23 22:41:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-23 22:44:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 22:44:16]

Try jobs failed on following builders:
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/21929)

[Taylor Brandstetter, 2017-02-24 09:05:39]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-02-24 09:05:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-24 09:17:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487927139501840,
"parent_rev": "07cda9475b5847b224e881be81ec5991d9010a15", "commit_rev":
"b5388d77489388e5a9941cca9b979f9cfb4c8f76"}

[commit-bot: I haz the power, 2017-02-24 09:17:47]

Description was changed from

==========
Move rtc_api_unittests into rtc_unittests.

This avoids adding an additional test target. Plus, everything in
rtc_api_unittests is (and likely will be) simple utility classes akin to
what's already being tested in rtc_unittests.

BUG=None
TBR=kjellander@webrtc.org
==========

to

==========
Move rtc_api_unittests into rtc_unittests.

This avoids adding an additional test target. Plus, everything in
rtc_api_unittests is (and likely will be) simple utility classes akin to
what's already being tested in rtc_unittests.

BUG=None
TBR=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2709573003
Cr-Commit-Position: refs/heads/master@{#16819}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b5388d77489388e5a9941cca9...
==========

[commit-bot: I haz the power, 2017-02-24 09:17:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/b5388d77489388e5a9941cca9...