Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 2708843002: Move rtc_task_runner dependency from rtc_base to rtc_base_unittests. (Closed)

Created:
3 years, 10 months ago by nisse-webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move rtc_task_runner dependency from rtc_base to rtc_base_unittests. This is step 3 in the task runner migration process started in cl https://codereview.webrtc.org/2696703009/. It depends on step 2 being landed in Chrome, cl https://codereview.chromium.org/2694363005/. NOTRY=true BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2708843002 Cr-Commit-Position: refs/heads/master@{#16774} Committed: https://chromium.googlesource.com/external/webrtc/+/1d4e3d8a2ec0a138d1340e0d8643d69313a2194b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/base/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
nisse-webrtc
Preparing for step 3.
3 years, 10 months ago (2017-02-21 08:28:23 UTC) #2
kjellander_webrtc
lgtm I really like the disciplined execution of this.
3 years, 10 months ago (2017-02-21 08:30:51 UTC) #3
pthatcher1
lgtm
3 years, 10 months ago (2017-02-21 22:57:50 UTC) #5
nisse-webrtc
Step 2 was just landed in Chrome. Running the FYI bots, then landing this one.
3 years, 10 months ago (2017-02-22 12:19:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2708843002/1
3 years, 10 months ago (2017-02-22 13:23:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/1738)
3 years, 10 months ago (2017-02-22 13:54:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2708843002/1
3 years, 10 months ago (2017-02-22 13:59:41 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 14:03:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1d4e3d8a2ec0a138d1340e0d8...

Powered by Google App Engine
This is Rietveld 408576698