Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2707263010: Disable RTCStatsIntegrationTest on TSAN bots. (Closed)

Created:
3 years, 10 months ago by philipel
Modified:
3 years, 10 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, nisse-webrtc, Taylor Brandstetter
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable RTCStatsIntegrationTest on TSAN bots. BUG=webrtc:7231 TBR=tommi@webrtc.org Review-Url: https://codereview.webrtc.org/2707263010 Cr-Commit-Position: refs/heads/master@{#16828} Committed: https://chromium.googlesource.com/external/webrtc/+/1498defa78fb7b9263cf1db99efea517608c222b

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added reference to bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/pc/rtcstats_integrationtest.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2707263010/1
3 years, 10 months ago (2017-02-24 14:37:28 UTC) #4
hbos
https://codereview.webrtc.org/2707263010/diff/1/webrtc/pc/rtcstats_integrationtest.cc File webrtc/pc/rtcstats_integrationtest.cc (right): https://codereview.webrtc.org/2707263010/diff/1/webrtc/pc/rtcstats_integrationtest.cc#newcode619 webrtc/pc/rtcstats_integrationtest.cc:619: #if !defined(THREAD_SANITIZER) A comment referencing the bug would be ...
3 years, 10 months ago (2017-02-24 14:39:17 UTC) #6
philipel
On 2017/02/24 14:39:17, hbos wrote: > https://codereview.webrtc.org/2707263010/diff/1/webrtc/pc/rtcstats_integrationtest.cc > File webrtc/pc/rtcstats_integrationtest.cc (right): > > https://codereview.webrtc.org/2707263010/diff/1/webrtc/pc/rtcstats_integrationtest.cc#newcode619 > ...
3 years, 10 months ago (2017-02-24 14:43:35 UTC) #8
hbos
lgtm
3 years, 10 months ago (2017-02-24 14:50:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2707263010/20001
3 years, 10 months ago (2017-02-24 14:51:19 UTC) #11
hbos
On 2017/02/24 14:50:55, hbos wrote: > lgtm Possible fix: https://codereview.webrtc.org/2710363003/
3 years, 10 months ago (2017-02-24 14:54:21 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 15:41:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/1498defa78fb7b9263cf1db99...

Powered by Google App Engine
This is Rietveld 408576698