Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: webrtc/pc/rtcstats_integrationtest.cc

Issue 2707263010: Disable RTCStatsIntegrationTest on TSAN bots. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 598 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 transport.local_certificate_id, RTCCertificateStats::kType); 609 transport.local_certificate_id, RTCCertificateStats::kType);
610 verifier.TestMemberIsIDReference( 610 verifier.TestMemberIsIDReference(
611 transport.remote_certificate_id, RTCCertificateStats::kType); 611 transport.remote_certificate_id, RTCCertificateStats::kType);
612 return verifier.ExpectAllMembersSuccessfullyTested(); 612 return verifier.ExpectAllMembersSuccessfullyTested();
613 } 613 }
614 614
615 private: 615 private:
616 rtc::scoped_refptr<const RTCStatsReport> report_; 616 rtc::scoped_refptr<const RTCStatsReport> report_;
617 }; 617 };
618 618
619 #if !defined(THREAD_SANITIZER)
hbos 2017/02/24 14:39:17 A comment referencing the bug would be nice.
619 #ifdef HAVE_SCTP 620 #ifdef HAVE_SCTP
620 TEST_F(RTCStatsIntegrationTest, GetStatsFromCaller) { 621 TEST_F(RTCStatsIntegrationTest, GetStatsFromCaller) {
621 StartCall(); 622 StartCall();
622 623
623 rtc::scoped_refptr<const RTCStatsReport> report = GetStatsFromCaller(); 624 rtc::scoped_refptr<const RTCStatsReport> report = GetStatsFromCaller();
624 RTCStatsReportVerifier(report.get()).VerifyReport(); 625 RTCStatsReportVerifier(report.get()).VerifyReport();
625 } 626 }
626 627
627 TEST_F(RTCStatsIntegrationTest, GetStatsFromCallee) { 628 TEST_F(RTCStatsIntegrationTest, GetStatsFromCallee) {
628 StartCall(); 629 StartCall();
629 630
630 rtc::scoped_refptr<const RTCStatsReport> report = GetStatsFromCallee(); 631 rtc::scoped_refptr<const RTCStatsReport> report = GetStatsFromCallee();
631 RTCStatsReportVerifier(report.get()).VerifyReport(); 632 RTCStatsReportVerifier(report.get()).VerifyReport();
632 } 633 }
633 634
634 TEST_F(RTCStatsIntegrationTest, GetsStatsWhileDestroyingPeerConnections) { 635 TEST_F(RTCStatsIntegrationTest, GetsStatsWhileDestroyingPeerConnections) {
635 StartCall(); 636 StartCall();
636 637
637 rtc::scoped_refptr<RTCStatsObtainer> stats_obtainer = 638 rtc::scoped_refptr<RTCStatsObtainer> stats_obtainer =
638 RTCStatsObtainer::Create(); 639 RTCStatsObtainer::Create();
639 caller_->pc()->GetStats(stats_obtainer); 640 caller_->pc()->GetStats(stats_obtainer);
640 // This will destroy the peer connection. 641 // This will destroy the peer connection.
641 caller_ = nullptr; 642 caller_ = nullptr;
642 // Any pending stats requests should have completed in the act of destroying 643 // Any pending stats requests should have completed in the act of destroying
643 // the peer connection. 644 // the peer connection.
644 EXPECT_TRUE(stats_obtainer->report()); 645 EXPECT_TRUE(stats_obtainer->report());
645 } 646 }
646 #endif // HAVE_SCTP 647 #endif // HAVE_SCTP
648 #endif // !defined(THREAD_SANITIZER)
647 649
648 } // namespace 650 } // namespace
649 651
650 } // namespace webrtc 652 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698