Issue 2706223002: RembWithSendSideBwe: Rename |event_| to |stop_event_| and set it when the test ends.

Issue 2706223002: RembWithSendSideBwe: Rename |event_| to |stop_event_| and set it when the test ends. (Closed)

Created:
3 years, 10 months ago by tommi

Modified:
3 years, 10 months ago

Reviewers:
stefan-webrtc

CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman

Target Ref:
refs/heads/master

Project:
webrtc

Visibility:
Public.

RembWithSendSideBwe: Rename |event_| to |stop_event_| and set it when the test ends. BUG=webrtc:7200 R=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2706223002 . Cr-Commit-Position: refs/heads/master@{#16744} Committed: https://chromium.googlesource.com/external/webrtc/+/5dd5f5a3195c3a5fd26b6008992bb18af73d42d2

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	webrtc/video/end_to_end_tests.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 9 (5 generated)

stefan-webrtc

This saves us up to 1 second in test execution time, right? lgtm

3 years, 10 months ago (2017-02-21 12:53:01 UTC) #5

tommi

On 2017/02/21 12:53:01, stefan-webrtc wrote: > This saves us up to 1 second in test ...

3 years, 10 months ago (2017-02-21 13:04:56 UTC) #6

tommi

3 years, 10 months ago (2017-02-21 13:23:05 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5dd5f5a3195c3a5fd26b6008992bb18af73d42d2 (presubmit successful).