Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 2706223002: RembWithSendSideBwe: Rename |event_| to |stop_event_| and set it when the test ends. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index a029f58044d0d5e17067689236941d8dc62597da..bf512d2592c5233493f9c459a686ea95e4fd9bdd 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -2095,7 +2095,7 @@ TEST_P(EndToEndTest, RembWithSendSideBwe) {
sender_ssrc_(0),
remb_bitrate_bps_(1000000),
receive_transport_(nullptr),
- event_(false, false),
+ stop_event_(false, false),
poller_thread_(&BitrateStatsPollingThread,
this,
"BitrateStatsPollingThread"),
@@ -2183,13 +2183,14 @@ TEST_P(EndToEndTest, RembWithSendSideBwe) {
}
}
- return !event_.Wait(1000);
+ return !stop_event_.Wait(1000);
}
void PerformTest() override {
poller_thread_.Start();
EXPECT_TRUE(Wait())
<< "Timed out while waiting for bitrate to change according to REMB.";
+ stop_event_.Set();
poller_thread_.Stop();
}
@@ -2202,7 +2203,7 @@ TEST_P(EndToEndTest, RembWithSendSideBwe) {
int remb_bitrate_bps_;
std::unique_ptr<RtpRtcp> rtp_rtcp_;
test::PacketTransport* receive_transport_;
- rtc::Event event_;
+ rtc::Event stop_event_;
rtc::PlatformThread poller_thread_;
TestState state_;
RateLimiter retransmission_rate_limiter_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698