Reland of Add optional visualization file writers to VideoProcessor tests.

Reland of Add optional visualization file writers to VideoProcessor tests. (patchset #1 id:1 of https://codereview.webrtc.org/2708103002/ )

Reason for revert:
Necessary calls were "protected" by RTC_DCHECKs, that were optimized away in some release builds.
Replacing the RTC_DCHECKs with EXPECTs.

Original issue's description:
> Revert of Add optional visualization file writers to VideoProcessor tests. (patchset #4 id:220001 of https://codereview.webrtc.org/2700493006/ )
> 
> Reason for revert:
> Breaks downstream project.
> 
> Original issue's description:
> > Add optional visualization file writers to VideoProcessor tests.
> > 
> > The purpose of this visualization CL is to add the ability to record
> > video at the source, after encode, and after decode, in the VideoProcessor
> > tests. These output files can then be replayed and used as a subjective
> > complement to the objective metric plots given by the existing Python
> > plotting script.
> > 
> > BUG=webrtc:6634
> > 
> > Review-Url: https://codereview.webrtc.org/2700493006
> > Cr-Commit-Position: refs/heads/master@{#16738}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/872104ac41d7764f8676c9ea55555210bea4605c
> 
> TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6634
> 
> Review-Url: https://codereview.webrtc.org/2708103002
> Cr-Commit-Position: refs/heads/master@{#16745}
> Committed: https://chromium.googlesource.com/external/webrtc/+/2a8135a1741761bd6de52163c0dc35f6eff7c8eb

TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2706123003
Cr-Commit-Position: refs/heads/master@{#16769}
Committed: https://chromium.googlesource.com/external/webrtc/+/b78bc75e8c459d02b84dbadd2c5a7d0c831c81f7

[brandtr, 2017-02-21 14:25:56]

Created Reland of Add optional visualization file writers to VideoProcessor
tests.

[brandtr, 2017-02-21 17:02:26]

Description was changed from

==========
Reland of Add optional visualization file writers to VideoProcessor tests.
(patchset #1 id:1 of https://codereview.webrtc.org/2708103002/ )

Reason for revert:
Investigating breakage.

Original issue's description:
> Revert of Add optional visualization file writers to VideoProcessor tests.
(patchset #4 id:220001 of https://codereview.webrtc.org/2700493006/ )
> 
> Reason for revert:
> Breaks downstream project.
> 
> Original issue's description:
> > Add optional visualization file writers to VideoProcessor tests.
> > 
> > The purpose of this visualization CL is to add the ability to record
> > video at the source, after encode, and after decode, in the VideoProcessor
> > tests. These output files can then be replayed and used as a subjective
> > complement to the objective metric plots given by the existing Python
> > plotting script.
> > 
> > BUG=webrtc:6634
> > 
> > Review-Url: https://codereview.webrtc.org/2700493006
> > Cr-Commit-Position: refs/heads/master@{#16738}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/872104ac41d7764f8676c9ea5...
> 
> TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6634
> 
> Review-Url: https://codereview.webrtc.org/2708103002
> Cr-Commit-Position: refs/heads/master@{#16745}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/2a8135a1741761bd6de52163c...

TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6634
==========

to

==========
Reland of Add optional visualization file writers to VideoProcessor tests.
(patchset #1 id:1 of https://codereview.webrtc.org/2708103002/ )

Reason for revert:
Necessary calls were "protected" by RTC_DCHECKs, that were optimized away in
some release builds.
Replacing the RTC_DCHECKs with EXPECTs.

Original issue's description:
> Revert of Add optional visualization file writers to VideoProcessor tests.
(patchset #4 id:220001 of https://codereview.webrtc.org/2700493006/ )
> 
> Reason for revert:
> Breaks downstream project.
> 
> Original issue's description:
> > Add optional visualization file writers to VideoProcessor tests.
> > 
> > The purpose of this visualization CL is to add the ability to record
> > video at the source, after encode, and after decode, in the VideoProcessor
> > tests. These output files can then be replayed and used as a subjective
> > complement to the objective metric plots given by the existing Python
> > plotting script.
> > 
> > BUG=webrtc:6634
> > 
> > Review-Url: https://codereview.webrtc.org/2700493006
> > Cr-Commit-Position: refs/heads/master@{#16738}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/872104ac41d7764f8676c9ea5...
> 
> TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6634
> 
> Review-Url: https://codereview.webrtc.org/2708103002
> Cr-Commit-Position: refs/heads/master@{#16745}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/2a8135a1741761bd6de52163c...

TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6634
==========

[brandtr, 2017-02-22 07:58:41]

Description was changed from

==========
Reland of Add optional visualization file writers to VideoProcessor tests.
(patchset #1 id:1 of https://codereview.webrtc.org/2708103002/ )

Reason for revert:
Necessary calls were "protected" by RTC_DCHECKs, that were optimized away in
some release builds.
Replacing the RTC_DCHECKs with EXPECTs.

Original issue's description:
> Revert of Add optional visualization file writers to VideoProcessor tests.
(patchset #4 id:220001 of https://codereview.webrtc.org/2700493006/ )
> 
> Reason for revert:
> Breaks downstream project.
> 
> Original issue's description:
> > Add optional visualization file writers to VideoProcessor tests.
> > 
> > The purpose of this visualization CL is to add the ability to record
> > video at the source, after encode, and after decode, in the VideoProcessor
> > tests. These output files can then be replayed and used as a subjective
> > complement to the objective metric plots given by the existing Python
> > plotting script.
> > 
> > BUG=webrtc:6634
> > 
> > Review-Url: https://codereview.webrtc.org/2700493006
> > Cr-Commit-Position: refs/heads/master@{#16738}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/872104ac41d7764f8676c9ea5...
> 
> TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6634
> 
> Review-Url: https://codereview.webrtc.org/2708103002
> Cr-Commit-Position: refs/heads/master@{#16745}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/2a8135a1741761bd6de52163c...

TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6634
==========

to

==========
Reland of Add optional visualization file writers to VideoProcessor tests.
(patchset #1 id:1 of https://codereview.webrtc.org/2708103002/ )

Reason for revert:
Necessary calls were "protected" by RTC_DCHECKs, that were optimized away in
some release builds.
Replacing the RTC_DCHECKs with EXPECTs.

Original issue's description:
> Revert of Add optional visualization file writers to VideoProcessor tests.
(patchset #4 id:220001 of https://codereview.webrtc.org/2700493006/ )
> 
> Reason for revert:
> Breaks downstream project.
> 
> Original issue's description:
> > Add optional visualization file writers to VideoProcessor tests.
> > 
> > The purpose of this visualization CL is to add the ability to record
> > video at the source, after encode, and after decode, in the VideoProcessor
> > tests. These output files can then be replayed and used as a subjective
> > complement to the objective metric plots given by the existing Python
> > plotting script.
> > 
> > BUG=webrtc:6634
> > 
> > Review-Url: https://codereview.webrtc.org/2700493006
> > Cr-Commit-Position: refs/heads/master@{#16738}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/872104ac41d7764f8676c9ea5...
> 
> TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6634
> 
> Review-Url: https://codereview.webrtc.org/2708103002
> Cr-Commit-Position: refs/heads/master@{#16745}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/2a8135a1741761bd6de52163c...

TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
BUG=webrtc:6634
==========

[brandtr, 2017-02-22 08:03:43]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 08:03:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[brandtr, 2017-02-22 08:52:47]

The CQ bit was unchecked by brandtr@webrtc.org

[brandtr, 2017-02-22 08:52:52]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2017-02-22 08:52:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-22 09:27:00]

CQ is committing da patch.

Bot data: {"patchset_id": 270001, "attempt_start_ts": 1487753572101180,
"parent_rev": "798781299f07ac73e61ea10a8cfbeea243884084", "commit_rev":
"b78bc75e8c459d02b84dbadd2c5a7d0c831c81f7"}

[commit-bot: I haz the power, 2017-02-22 09:27:02]

Description was changed from

==========
Reland of Add optional visualization file writers to VideoProcessor tests.
(patchset #1 id:1 of https://codereview.webrtc.org/2708103002/ )

Reason for revert:
Necessary calls were "protected" by RTC_DCHECKs, that were optimized away in
some release builds.
Replacing the RTC_DCHECKs with EXPECTs.

Original issue's description:
> Revert of Add optional visualization file writers to VideoProcessor tests.
(patchset #4 id:220001 of https://codereview.webrtc.org/2700493006/ )
> 
> Reason for revert:
> Breaks downstream project.
> 
> Original issue's description:
> > Add optional visualization file writers to VideoProcessor tests.
> > 
> > The purpose of this visualization CL is to add the ability to record
> > video at the source, after encode, and after decode, in the VideoProcessor
> > tests. These output files can then be replayed and used as a subjective
> > complement to the objective metric plots given by the existing Python
> > plotting script.
> > 
> > BUG=webrtc:6634
> > 
> > Review-Url: https://codereview.webrtc.org/2700493006
> > Cr-Commit-Position: refs/heads/master@{#16738}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/872104ac41d7764f8676c9ea5...
> 
> TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6634
> 
> Review-Url: https://codereview.webrtc.org/2708103002
> Cr-Commit-Position: refs/heads/master@{#16745}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/2a8135a1741761bd6de52163c...

TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
BUG=webrtc:6634
==========

to

==========
Reland of Add optional visualization file writers to VideoProcessor tests.
(patchset #1 id:1 of https://codereview.webrtc.org/2708103002/ )

Reason for revert:
Necessary calls were "protected" by RTC_DCHECKs, that were optimized away in
some release builds.
Replacing the RTC_DCHECKs with EXPECTs.

Original issue's description:
> Revert of Add optional visualization file writers to VideoProcessor tests.
(patchset #4 id:220001 of https://codereview.webrtc.org/2700493006/ )
> 
> Reason for revert:
> Breaks downstream project.
> 
> Original issue's description:
> > Add optional visualization file writers to VideoProcessor tests.
> > 
> > The purpose of this visualization CL is to add the ability to record
> > video at the source, after encode, and after decode, in the VideoProcessor
> > tests. These output files can then be replayed and used as a subjective
> > complement to the objective metric plots given by the existing Python
> > plotting script.
> > 
> > BUG=webrtc:6634
> > 
> > Review-Url: https://codereview.webrtc.org/2700493006
> > Cr-Commit-Position: refs/heads/master@{#16738}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/872104ac41d7764f8676c9ea5...
> 
> TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6634
> 
> Review-Url: https://codereview.webrtc.org/2708103002
> Cr-Commit-Position: refs/heads/master@{#16745}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/2a8135a1741761bd6de52163c...

TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/2706123003
Cr-Commit-Position: refs/heads/master@{#16769}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b78bc75e8c459d02b84dbadd2...
==========

[commit-bot: I haz the power, 2017-02-22 09:27:03]

Committed patchset #3 (id:270001) as
https://chromium.googlesource.com/external/webrtc/+/b78bc75e8c459d02b84dbadd2...