Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2708103002: Revert of Add optional visualization file writers to VideoProcessor tests. (Closed)

Created:
3 years, 10 months ago by brandtr
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add optional visualization file writers to VideoProcessor tests. (patchset #4 id:220001 of https://codereview.webrtc.org/2700493006/ ) Reason for revert: Breaks downstream project. Original issue's description: > Add optional visualization file writers to VideoProcessor tests. > > The purpose of this visualization CL is to add the ability to record > video at the source, after encode, and after decode, in the VideoProcessor > tests. These output files can then be replayed and used as a subjective > complement to the objective metric plots given by the existing Python > plotting script. > > BUG=webrtc:6634 > > Review-Url: https://codereview.webrtc.org/2700493006 > Cr-Commit-Position: refs/heads/master@{#16738} > Committed: https://chromium.googlesource.com/external/webrtc/+/872104ac41d7764f8676c9ea55555210bea4605c TBR=asapersson@webrtc.org,sprang@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2708103002 Cr-Commit-Position: refs/heads/master@{#16745} Committed: https://chromium.googlesource.com/external/webrtc/+/2a8135a1741761bd6de52163c0dc35f6eff7c8eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -731 lines) Patch
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 3 chunks +1 line, -8 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 3 chunks +6 lines, -22 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 11 chunks +35 lines, -72 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 13 chunks +39 lines, -108 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 13 chunks +16 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc View 2 chunks +8 lines, -11 lines 0 comments Download
M webrtc/test/BUILD.gn View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/test/testsupport/frame_reader.h View 2 chunks +6 lines, -6 lines 0 comments Download
A webrtc/test/testsupport/frame_reader.cc View 1 chunk +84 lines, -0 lines 0 comments Download
A webrtc/test/testsupport/frame_reader_unittest.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M webrtc/test/testsupport/frame_writer.h View 1 chunk +7 lines, -25 lines 0 comments Download
A webrtc/test/testsupport/frame_writer.cc View 1 chunk +70 lines, -0 lines 0 comments Download
A webrtc/test/testsupport/frame_writer_unittest.cc View 1 chunk +63 lines, -0 lines 0 comments Download
D webrtc/test/testsupport/y4m_frame_writer.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D webrtc/test/testsupport/y4m_frame_writer_unittest.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D webrtc/test/testsupport/yuv_frame_reader.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D webrtc/test/testsupport/yuv_frame_reader_unittest.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D webrtc/test/testsupport/yuv_frame_writer.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D webrtc/test/testsupport/yuv_frame_writer_unittest.cc View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
brandtr
Created Revert of Add optional visualization file writers to VideoProcessor tests.
3 years, 10 months ago (2017-02-21 13:23:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2708103002/1
3 years, 10 months ago (2017-02-21 13:23:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/2a8135a1741761bd6de52163c0dc35f6eff7c8eb
3 years, 10 months ago (2017-02-21 13:24:07 UTC) #6
brandtr
3 years, 10 months ago (2017-02-21 14:25:55 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2706123003/ by brandtr@webrtc.org.

The reason for reverting is: Investigating breakage..

Powered by Google App Engine
This is Rietveld 408576698