Replace test::FrameGenerator::ChromaGenerator with new FrameGenerator::SquareGenerator

Replace test::FrameGenerator::ChromaGenerator with new FrameGenerator::SquareGenerator The problem with the ChromaGenerator is that the VP8 encoder produce a too low bitrate for each frame. The squaregenerator make the VP8 encoder produce about 600kbit/s at VGA.

SquareGenerator is a FrameGenerator that draws 10 randomly sized and colored
squares. Between each new generated frame, the squares are moved slightly
towards the lower right corner.

BUG=webrtc:7192
Review-Url: https://codereview.webrtc.org/2705973002
Cr-Commit-Position: refs/heads/master@{#16870}
Committed: https://chromium.googlesource.com/external/webrtc/+/a8ba195db5c697c27fe0a224e7d47e6c981d387a

[perkj_webrtc, 2017-02-20 08:20:41]

Patchset #1 (id:1) has been deleted

[perkj_webrtc, 2017-02-20 08:20:46]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 08:20:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[perkj_webrtc, 2017-02-20 08:21:20]

perkj@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[perkj_webrtc, 2017-02-20 08:21:21]

please?

[commit-bot: I haz the power, 2017-02-20 08:37:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 08:37:36]

Dry run: Try jobs failed on following builders:
  linux_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/23301)

[perkj_webrtc, 2017-02-20 10:12:14]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 10:12:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-20 10:23:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 10:23:09]

Dry run: Try jobs failed on following builders:
  linux_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/23306)

[perkj_webrtc, 2017-02-20 11:45:54]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 11:46:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[perkj_webrtc, 2017-02-20 12:13:53]

Description was changed from

==========
Replace test::FrameGenerator::ChromaGenerator with new
FrameGenerator::SquareGenerator The problem with the ChromaGenerator is that the
VP8 encoder produce a too low bitrate for each frame. The squaregenerator make
the VP8 encoder produce about 600kbit/s at VGA.

SquareGenerator is a FrameGenerator that draws 10 randomly sized and colored
squares. Between each new generated frame, the squares are moved slightly
towards the lower right corner.

BUG=webrtc:7192
==========

to

==========
Replace test::FrameGenerator::ChromaGenerator with new
FrameGenerator::SquareGenerator The problem with the ChromaGenerator is that the
VP8 encoder produce a too low bitrate for each frame. The squaregenerator make
the VP8 encoder produce about 600kbit/s at VGA.

SquareGenerator is a FrameGenerator that draws 10 randomly sized and colored
squares. Between each new generated frame, the squares are moved slightly
towards the lower right corner.

BUG=webrtc:7192
==========

[commit-bot: I haz the power, 2017-02-20 12:34:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 12:34:44]

Dry run: This issue passed the CQ dry run.

[perkj_webrtc, 2017-02-22 14:12:51]

On 2017/02/20 08:21:21, perkj_webrtc wrote:
> please?

ping?

[mflodman, 2017-02-24 15:37:54]

mflodman@webrtc.org changed reviewers:
+ stefan@webrtc.org

[mflodman, 2017-02-24 15:37:55]

One nit, then LGTM.

Stefan,
I'm not very familiar with the padding change in end_to_end_tests.cc, can you
just take a look at that specific change?

https://codereview.webrtc.org/2705973002/diff/80001/webrtc/test/frame_generat...
File webrtc/test/frame_generator.cc (right):

https://codereview.webrtc.org/2705973002/diff/80001/webrtc/test/frame_generat...
webrtc/test/frame_generator.cc:20: #include "webrtc/base/random.h"
Include order, move one line below.

[perkj_webrtc, 2017-02-27 14:30:36]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 14:30:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[stefan-webrtc, 2017-02-27 14:31:23]

lgtm after discussion offline

[perkj_webrtc, 2017-02-27 14:32:03]

https://codereview.webrtc.org/2705973002/diff/80001/webrtc/test/frame_generat...
File webrtc/test/frame_generator.cc (right):

https://codereview.webrtc.org/2705973002/diff/80001/webrtc/test/frame_generat...
webrtc/test/frame_generator.cc:20: #include "webrtc/base/random.h"
On 2017/02/24 15:37:55, mflodman wrote:
> Include order, move one line below.

Done.

[perkj_webrtc, 2017-02-27 14:32:09]

The CQ bit was unchecked by perkj@webrtc.org

[perkj_webrtc, 2017-02-27 14:32:09]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2017-02-27 14:32:10]

The patchset sent to the CQ was uploaded after l-g-t-m from mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2705973002/#ps120001 (title:
"addressed comments.")

[commit-bot: I haz the power, 2017-02-27 14:32:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-27 14:52:11]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1488205929627500,
"parent_rev": "adc41f3c82f23f6c0dda09a63ded5baf1d4e1031", "commit_rev":
"a8ba195db5c697c27fe0a224e7d47e6c981d387a"}

[commit-bot: I haz the power, 2017-02-27 14:52:14]

Description was changed from

==========
Replace test::FrameGenerator::ChromaGenerator with new
FrameGenerator::SquareGenerator The problem with the ChromaGenerator is that the
VP8 encoder produce a too low bitrate for each frame. The squaregenerator make
the VP8 encoder produce about 600kbit/s at VGA.

SquareGenerator is a FrameGenerator that draws 10 randomly sized and colored
squares. Between each new generated frame, the squares are moved slightly
towards the lower right corner.

BUG=webrtc:7192
==========

to

==========
Replace test::FrameGenerator::ChromaGenerator with new
FrameGenerator::SquareGenerator The problem with the ChromaGenerator is that the
VP8 encoder produce a too low bitrate for each frame. The squaregenerator make
the VP8 encoder produce about 600kbit/s at VGA.

SquareGenerator is a FrameGenerator that draws 10 randomly sized and colored
squares. Between each new generated frame, the squares are moved slightly
towards the lower right corner.

BUG=webrtc:7192

Review-Url: https://codereview.webrtc.org/2705973002
Cr-Commit-Position: refs/heads/master@{#16870}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a8ba195db5c697c27fe0a224e...
==========

[commit-bot: I haz the power, 2017-02-27 14:52:15]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/a8ba195db5c697c27fe0a224e...