Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Side by Side Diff: webrtc/modules/video_coding/video_sender_unittest.cc

Issue 2705973002: Replace test::FrameGenerator::ChromaGenerator with new FrameGenerator::SquareGenerator (Closed)
Patch Set: addressed comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/test/frame_generator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 386 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 public: 397 public:
398 TestVideoSenderWithVp8() 398 TestVideoSenderWithVp8()
399 : codec_bitrate_kbps_(300), available_bitrate_kbps_(1000) {} 399 : codec_bitrate_kbps_(300), available_bitrate_kbps_(1000) {}
400 400
401 void SetUp() override { 401 void SetUp() override {
402 TestVideoSender::SetUp(); 402 TestVideoSender::SetUp();
403 403
404 const char* input_video = "foreman_cif"; 404 const char* input_video = "foreman_cif";
405 const int width = 352; 405 const int width = 352;
406 const int height = 288; 406 const int height = 288;
407 generator_.reset(FrameGenerator::CreateFromYuvFile( 407 generator_ = FrameGenerator::CreateFromYuvFile(
408 std::vector<std::string>(1, test::ResourcePath(input_video, "yuv")), 408 std::vector<std::string>(1, test::ResourcePath(input_video, "yuv")),
409 width, height, 1)); 409 width, height, 1);
410 410
411 codec_ = MakeVp8VideoCodec(width, height, 3); 411 codec_ = MakeVp8VideoCodec(width, height, 3);
412 codec_.minBitrate = 10; 412 codec_.minBitrate = 10;
413 codec_.startBitrate = codec_bitrate_kbps_; 413 codec_.startBitrate = codec_bitrate_kbps_;
414 codec_.maxBitrate = codec_bitrate_kbps_; 414 codec_.maxBitrate = codec_bitrate_kbps_;
415 415
416 TemporalLayersFactory* tl_factory = new TemporalLayersFactory(); 416 TemporalLayersFactory* tl_factory = new TemporalLayersFactory();
417 rate_allocator_.reset(new SimulcastRateAllocator( 417 rate_allocator_.reset(new SimulcastRateAllocator(
418 codec_, std::unique_ptr<TemporalLayersFactory>(tl_factory))); 418 codec_, std::unique_ptr<TemporalLayersFactory>(tl_factory)));
419 codec_.VP8()->tl_factory = tl_factory; 419 codec_.VP8()->tl_factory = tl_factory;
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
529 } 529 }
530 { 530 {
531 // TODO(andresp): Find out why this fails with framerate = 7.5 531 // TODO(andresp): Find out why this fails with framerate = 7.5
532 Vp8StreamInfo expected = {{7.0, 7.0, 7.0}, {high_b, high_b, high_b}}; 532 Vp8StreamInfo expected = {{7.0, 7.0, 7.0}, {high_b, high_b, high_b}};
533 EXPECT_THAT(SimulateWithFramerate(7.0), MatchesVp8StreamInfo(expected)); 533 EXPECT_THAT(SimulateWithFramerate(7.0), MatchesVp8StreamInfo(expected));
534 } 534 }
535 } 535 }
536 } // namespace 536 } // namespace
537 } // namespace vcm 537 } // namespace vcm
538 } // namespace webrtc 538 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/test/frame_generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698