Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2705153004: Handle TypeVariable and TypeVariables in AstBuilder. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -24 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 6 chunks +3 lines, -24 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 1 chunk +22 lines, -0 lines 5 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
3 years, 10 months ago (2017-02-21 19:14:11 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right): https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart#newcode1000 pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1000: void endTypeVariable(Token token, Token extendsOrSuper) { What means ...
3 years, 10 months ago (2017-02-21 19:19:26 UTC) #3
Paul Berry
https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right): https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart#newcode1000 pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1000: void endTypeVariable(Token token, Token extendsOrSuper) { On 2017/02/21 19:19:26, ...
3 years, 10 months ago (2017-02-21 20:00:25 UTC) #4
Paul Berry
Committed patchset #1 (id:1) manually as 7647e90abb94a7a55ca0193e8c9c3802bde94846 (presubmit successful).
3 years, 10 months ago (2017-02-21 20:00:40 UTC) #6
ahe
3 years, 10 months ago (2017-02-22 10:35:45 UTC) #7
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1000: void
endTypeVariable(Token token, Token extendsOrSuper) {
On 2017/02/21 20:00:25, Paul Berry wrote:
> On 2017/02/21 19:19:26, scheglov wrote:
> > What means "OrSuper" here?
> > Did I miss something from the language specification?
> 
> I copied it from the base class.  I think it's a sign of a bug.  See
> https://github.com/dart-lang/sdk/issues/28848

Yes. This is a bug.

Powered by Google App Engine
This is Rietveld 408576698