Handle TypeVariable and TypeVariables in AstBuilder.

pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.analyzer.ast_builder;
 
 import 'package:front_end/src/fasta/scanner/token.dart'
     show BeginGroupToken, Token;
 
 import 'package:analyzer/analyzer.dart';
@@ skipping 977 matching lines @@
     }
     var variableList = ast.variableDeclarationList(
         null, null, toAnalyzerToken(keyword), type, variables);
     var modifiers = pop();
     assert(modifiers == null); // TODO(paulberry)
     List<Annotation> metadata = pop();
     Comment comment = null; // TODO(paulberry)
     push(ast.topLevelVariableDeclaration(
         comment, metadata, variableList, toAnalyzerToken(endToken)));
   }
+
+  @override
+  void endTypeVariable(Token token, Token extendsOrSuper) {

[scheglov, 2017/02/21 19:19:26]

What means "OrSuper" here?
Did I miss something from the language specification?

[Paul Berry, 2017/02/21 20:00:25]

I copied it from the base class.  I think it's a sign of a bug.  See
https://github.com/dart-lang/sdk/issues/28848

[ahe, 2017/02/22 10:35:45]

Yes. This is a bug.

+    // TODO(paulberry): set up scopes properly to resolve parameters and type
+    // variables.  Note that this is tricky due to the handling of initializers
+    // in constructors, so the logic should be shared with BodyBuilder as much
+    // as possible.
+    debugEvent("TypeVariable");
+    TypeAnnotation bound = pop();
+    SimpleIdentifier name = pop();
+    List<Annotation> metadata = null; // TODO(paulberry)
+    Comment comment = null; // TODO(paulberry)
+    push(ast.typeParameter(
+        comment, metadata, name, toAnalyzerToken(extendsOrSuper), bound));
+  }
+
+  void endTypeVariables(int count, Token beginToken, Token endToken) {

[scheglov, 2017/02/21 19:19:26]

@override?

[Paul Berry, 2017/02/21 20:00:24]

Done.

+    debugEvent("TypeVariables");
+    List<TypeParameter> typeParameters = popList(count);
+    push(ast.typeParameterList(toAnalyzerToken(beginToken), typeParameters,
+        toAnalyzerToken(endToken)));
+  }
 }
 
 /// Data structure placed on the stack to represent a class body.
 ///
 /// This is needed because analyzer has no separate AST representation of a
 /// class body; it simply stores all of the relevant data in the
 /// [ClassDeclaration] object.
 class _ClassBody {
   final Token beginToken;
 
@@ skipping 12 matching lines @@
 /// [ClassDeclaration] or [ClassTypeAlias] object.
 class _MixinApplication {
   final TypeName supertype;
 
   final Token withKeyword;
 
   final List<TypeName> mixinTypes;
 
   _MixinApplication(this.supertype, this.withKeyword, this.mixinTypes);
 }