Handle TypeVariable and TypeVariables in AstBuilder.

Handle TypeVariable and TypeVariables in AstBuilder.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/7647e90abb94a7a55ca0193e8c9c3802bde94846

[Paul Berry, 2017-02-21 19:14:10]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[scheglov, 2017-02-21 19:19:26]

LGTM

https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1000: void
endTypeVariable(Token token, Token extendsOrSuper) {
What means "OrSuper" here?
Did I miss something from the language specification?

https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1014: void
endTypeVariables(int count, Token beginToken, Token endToken) {
@override?

[Paul Berry, 2017-02-21 20:00:25]

https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1000: void
endTypeVariable(Token token, Token extendsOrSuper) {
On 2017/02/21 19:19:26, scheglov wrote:
> What means "OrSuper" here?
> Did I miss something from the language specification?

I copied it from the base class.  I think it's a sign of a bug.  See
https://github.com/dart-lang/sdk/issues/28848

https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1014: void
endTypeVariables(int count, Token beginToken, Token endToken) {
On 2017/02/21 19:19:26, scheglov wrote:
> @override?

Done.

[Paul Berry, 2017-02-21 20:00:35]

Description was changed from

==========
Handle TypeVariable and TypeVariables in AstBuilder.
==========

to

==========
Handle TypeVariable and TypeVariables in AstBuilder.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7647e90abb94a7a55ca0193e8c9c3802bde94846
==========

[Paul Berry, 2017-02-21 20:00:40]

Committed patchset #1 (id:1) manually as
7647e90abb94a7a55ca0193e8c9c3802bde94846 (presubmit successful).

[ahe, 2017-02-22 10:35:45]

lgtm

https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2705153004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1000: void
endTypeVariable(Token token, Token extendsOrSuper) {
On 2017/02/21 20:00:25, Paul Berry wrote:
> On 2017/02/21 19:19:26, scheglov wrote:
> > What means "OrSuper" here?
> > Did I miss something from the language specification?
> 
> I copied it from the base class.  I think it's a sign of a bug.  See
> https://github.com/dart-lang/sdk/issues/28848

Yes. This is a bug.