Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2703613006: Revert of Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker. (patchset #2 id:20001 of https://codereview.webrtc.org/2689233003/ ) Reason for revert: The change to messagequeue.h isn't backwards compatible. Will reland after making it backwards compatible. Original issue's description: > Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker. > > The AsyncClosures only ever have one thing referencing them, so they > should be using std::unique_ptr to manage ownership. Maybe this code was > written before std::unique_ptr was available. > > BUG=None > > Review-Url: https://codereview.webrtc.org/2689233003 > Cr-Commit-Position: refs/heads/master@{#16680} > Committed: https://chromium.googlesource.com/external/webrtc/+/a5a472927bb209a053b2648d1f0b006f4c8c30ac TBR=pthatcher@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2703613006 Cr-Commit-Position: refs/heads/master@{#16683} Committed: https://chromium.googlesource.com/external/webrtc/+/884a7284bd11e46840006e92ea8b5fe52abdde27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -33 lines) Patch
M webrtc/base/asyncinvoker.h View 6 chunks +15 lines, -17 lines 0 comments Download
M webrtc/base/asyncinvoker.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M webrtc/base/asyncinvoker-inl.h View 2 chunks +7 lines, -3 lines 0 comments Download
M webrtc/base/messagequeue.h View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Taylor Brandstetter
Created Revert of Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.
3 years, 10 months ago (2017-02-17 23:56:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2703613006/1
3 years, 10 months ago (2017-02-17 23:56:57 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 23:57:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/884a7284bd11e46840006e92e...

Powered by Google App Engine
This is Rietveld 408576698