Relanding: Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

Relanding: Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

Originally reverted because it made a change to ScopedMessageData
that wasn't backwards compatible, and applications using the rtc::Thread
infrastructure may be using it.

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2689233003
Cr-Commit-Position: refs/heads/master@{#16684}
Committed: https://chromium.googlesource.com/external/webrtc/+/a8bc1a1f63ca8b899526b5af0203264f8f281772

[Taylor Brandstetter, 2017-02-14 04:19:59]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2017-02-14 04:19:59]

Something I noticed while working on the other CL that made me scratch my head.

[Taylor Brandstetter, 2017-02-16 01:57:42]

Ping

[pthatcher1, 2017-02-17 18:04:47]

lgtm

[Taylor Brandstetter, 2017-02-17 18:39:17]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-02-17 18:39:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Taylor Brandstetter, 2017-02-17 18:39:35]

Description was changed from

==========
Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures ever only have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

BUG=None
==========

to

==========
Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

BUG=None
==========

[commit-bot: I haz the power, 2017-02-17 19:27:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 19:28:00]

Try jobs failed on following builders:
  linux_memcheck on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/5349)

[Taylor Brandstetter, 2017-02-17 21:56:01]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-02-17 21:56:01]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2689233003/#ps20001 (title:
"Fixing memory leak (forgot delete statement)")

[commit-bot: I haz the power, 2017-02-17 21:56:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-17 22:09:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 22:09:56]

Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)

[Taylor Brandstetter, 2017-02-17 22:48:18]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-02-17 22:48:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-17 23:19:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487371698558880,
"parent_rev": "658c3bb0aba00142284bd464d1e2d693e53f931e", "commit_rev":
"a5a472927bb209a053b2648d1f0b006f4c8c30ac"}

[commit-bot: I haz the power, 2017-02-17 23:19:22]

Description was changed from

==========
Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

BUG=None
==========

to

==========
Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

BUG=None

Review-Url: https://codereview.webrtc.org/2689233003
Cr-Commit-Position: refs/heads/master@{#16680}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a5a472927bb209a053b2648d1...
==========

[commit-bot: I haz the power, 2017-02-17 23:19:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/a5a472927bb209a053b2648d1...

[Taylor Brandstetter, 2017-02-17 23:56:53]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2703613006/ by deadbeef@webrtc.org.

The reason for reverting is: The change to messagequeue.h isn't backwards
compatible. Will reland after making it backwards compatible..

[Taylor Brandstetter, 2017-02-17 23:57:38]

Description was changed from

==========
Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

BUG=None

Review-Url: https://codereview.webrtc.org/2689233003
Cr-Commit-Position: refs/heads/master@{#16680}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a5a472927bb209a053b2648d1...
==========

to

==========
Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

BUG=None

Review-Url: https://codereview.webrtc.org/2689233003
Cr-Commit-Position: refs/heads/master@{#16680}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a5a472927bb209a053b2648d1...
==========

[Taylor Brandstetter, 2017-02-18 00:05:33]

Description was changed from

==========
Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

BUG=None

Review-Url: https://codereview.webrtc.org/2689233003
Cr-Commit-Position: refs/heads/master@{#16680}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a5a472927bb209a053b2648d1...
==========

to

==========
Relanding: Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

Originally reverted because it made a change to ScopedMessageData
that wasn't backwards compatible, and applications using the rtc::Thread
infrastructure may be using it.

BUG=None

Review-Url: https://codereview.webrtc.org/2689233003
Cr-Commit-Position: refs/heads/master@{#16680}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a5a472927bb209a053b2648d1...
==========

[Taylor Brandstetter, 2017-02-18 00:05:47]

Description was changed from

==========
Relanding: Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

Originally reverted because it made a change to ScopedMessageData
that wasn't backwards compatible, and applications using the rtc::Thread
infrastructure may be using it.

BUG=None

Review-Url: https://codereview.webrtc.org/2689233003
Cr-Commit-Position: refs/heads/master@{#16680}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a5a472927bb209a053b2648d1...
==========

to

==========
Relanding: Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

Originally reverted because it made a change to ScopedMessageData
that wasn't backwards compatible, and applications using the rtc::Thread
infrastructure may be using it.

BUG=None
==========

[Taylor Brandstetter, 2017-02-18 00:09:49]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-02-18 00:09:49]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2689233003/#ps60001 (title:
".")

[commit-bot: I haz the power, 2017-02-18 00:09:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-18 01:35:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:36:02]

Try jobs failed on following builders:
  linux_ubsan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/9737)

[Taylor Brandstetter, 2017-02-18 02:03:23]

Description was changed from

==========
Relanding: Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

Originally reverted because it made a change to ScopedMessageData
that wasn't backwards compatible, and applications using the rtc::Thread
infrastructure may be using it.

BUG=None
==========

to

==========
Relanding: Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

Originally reverted because it made a change to ScopedMessageData
that wasn't backwards compatible, and applications using the rtc::Thread
infrastructure may be using it.

BUG=None
NOTRY=True
==========

[Taylor Brandstetter, 2017-02-18 02:03:32]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-02-18 02:03:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-18 02:06:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487383412247170,
"parent_rev": "884a7284bd11e46840006e92ea8b5fe52abdde27", "commit_rev":
"a8bc1a1f63ca8b899526b5af0203264f8f281772"}

[commit-bot: I haz the power, 2017-02-18 02:06:30]

Description was changed from

==========
Relanding: Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

Originally reverted because it made a change to ScopedMessageData
that wasn't backwards compatible, and applications using the rtc::Thread
infrastructure may be using it.

BUG=None
NOTRY=True
==========

to

==========
Relanding: Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker.

The AsyncClosures only ever have one thing referencing them, so they
should be using std::unique_ptr to manage ownership. Maybe this code was
written before std::unique_ptr was available.

Originally reverted because it made a change to ScopedMessageData
that wasn't backwards compatible, and applications using the rtc::Thread
infrastructure may be using it.

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2689233003
Cr-Commit-Position: refs/heads/master@{#16684}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a8bc1a1f63ca8b899526b5af0...
==========

[commit-bot: I haz the power, 2017-02-18 02:06:31]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/a8bc1a1f63ca8b899526b5af0...