Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2703503003: Re-land of RTCInboundRTPStreamStats.qpSum collected. (Closed)

Created:
3 years, 10 months ago by hbos
Modified:
3 years, 10 months ago
Reviewers:
hta-webrtc, sakal
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-land of RTCInboundRTPStreamStats.qpSum collected. This was previously only collected for local tracks (RTCOutboundRTPStreamStats.qpSum). Spec: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum This CL also improves some testing in rtcstatscollector_unittest.cc. Default and non-default values are tested in the same unittests, removing the test that was specific to default-values, which was otherwise code duplication. This is a re-land of https://codereview.webrtc.org/2675943002 after dependent CL that was re-landed. BUG=webrtc:7065 TBR=hta@webrtc.org, sakal@webrtc.org Review-Url: https://codereview.webrtc.org/2703503003 Cr-Commit-Position: refs/heads/master@{#16642} Committed: https://chromium.googlesource.com/external/webrtc/+/a51d4f34d950b4f31bb0db19cbbb936620e334ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -123 lines) Patch
M webrtc/api/stats/rtcstats_objects.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/pc/rtcstats_integrationtest.cc View 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/pc/rtcstatscollector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/pc/rtcstatscollector_unittest.cc View 7 chunks +60 lines, -120 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2703503003/1
3 years, 10 months ago (2017-02-16 12:49:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/a51d4f34d950b4f31bb0db19cbbb936620e334ab
3 years, 10 months ago (2017-02-16 13:34:54 UTC) #6
sakal
3 years, 10 months ago (2017-02-16 13:36:33 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698