Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2703503003: Re-land of RTCInboundRTPStreamStats.qpSum collected. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/pc/rtcstats_integrationtest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 RTCStatsMember<std::string> codec_id; 316 RTCStatsMember<std::string> codec_id;
317 // FIR and PLI counts are only defined for |media_type == "video"|. 317 // FIR and PLI counts are only defined for |media_type == "video"|.
318 RTCStatsMember<uint32_t> fir_count; 318 RTCStatsMember<uint32_t> fir_count;
319 RTCStatsMember<uint32_t> pli_count; 319 RTCStatsMember<uint32_t> pli_count;
320 // TODO(hbos): NACK count should be collected by |RTCStatsCollector| for both 320 // TODO(hbos): NACK count should be collected by |RTCStatsCollector| for both
321 // audio and video but is only defined in the "video" case. crbug.com/657856 321 // audio and video but is only defined in the "video" case. crbug.com/657856
322 RTCStatsMember<uint32_t> nack_count; 322 RTCStatsMember<uint32_t> nack_count;
323 // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854 323 // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854
324 // SLI count is only defined for |media_type == "video"|. 324 // SLI count is only defined for |media_type == "video"|.
325 RTCStatsMember<uint32_t> sli_count; 325 RTCStatsMember<uint32_t> sli_count;
326 // TODO(hbos): Only collected for the outbound case, should also be collected
327 // for inbound case by |RTCStatsCollector|. crbug.com/657854, crbug.com/657855
328 RTCStatsMember<uint64_t> qp_sum; 326 RTCStatsMember<uint64_t> qp_sum;
329 327
330 protected: 328 protected:
331 RTCRTPStreamStats(const std::string& id, int64_t timestamp_us); 329 RTCRTPStreamStats(const std::string& id, int64_t timestamp_us);
332 RTCRTPStreamStats(std::string&& id, int64_t timestamp_us); 330 RTCRTPStreamStats(std::string&& id, int64_t timestamp_us);
333 }; 331 };
334 332
335 // https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict* 333 // https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict*
336 // Tracking bug crbug.com/657855 334 // Tracking bug crbug.com/657855
337 // TODO(hbos): Support the remote case |is_remote = true|. crbug.com/657855 335 // TODO(hbos): Support the remote case |is_remote = true|. crbug.com/657855
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 // TODO(hbos): Support enum types? "RTCStatsMember<RTCDtlsTransportState>"? 408 // TODO(hbos): Support enum types? "RTCStatsMember<RTCDtlsTransportState>"?
411 RTCStatsMember<std::string> dtls_state; 409 RTCStatsMember<std::string> dtls_state;
412 RTCStatsMember<std::string> selected_candidate_pair_id; 410 RTCStatsMember<std::string> selected_candidate_pair_id;
413 RTCStatsMember<std::string> local_certificate_id; 411 RTCStatsMember<std::string> local_certificate_id;
414 RTCStatsMember<std::string> remote_certificate_id; 412 RTCStatsMember<std::string> remote_certificate_id;
415 }; 413 };
416 414
417 } // namespace webrtc 415 } // namespace webrtc
418 416
419 #endif // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_ 417 #endif // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/pc/rtcstats_integrationtest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698