Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2703333004: Rename config structs in VideoProcessor tests. (Closed)

Created:
3 years, 10 months ago by brandtr
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename config structs in VideoProcessor tests. This CL harmonizes and improves the naming of the config structs in the VideoProcessor tests. It should have no functional implications. CodecConfigPars -> CodecParams: This struct mainly contains codec settings. QualityMetrics -> QualityThresholds: This struct contains thresholds against which the calculated PSNR and SSIM metrics are compared to. RateControlMetrics -> RateControlThresholds: This struct contains thresholds against which the calculated rate control metrics are compared to. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2703333004 Cr-Commit-Position: refs/heads/master@{#16794} Committed: https://chromium.googlesource.com/external/webrtc/+/1e46434e7ef90da1aebaf28cb7ac0d674c857e7a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase fix. #

Patch Set 4 : Rebase. #

Total comments: 2

Patch Set 5 : sprang comments 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -334 lines) Patch
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 1 1 chunk +27 lines, -27 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 2 3 4 14 chunks +133 lines, -120 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 1 9 chunks +187 lines, -187 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
brandtr
https://codereview.webrtc.org/2703333004/diff/1/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h (left): https://codereview.webrtc.org/2703333004/diff/1/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h#oldcode83 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:83: double minimum_avg_psnr; 'minimum' -> 'min' to harmonize with RateControlThreshold ...
3 years, 10 months ago (2017-02-21 12:04:31 UTC) #2
åsapersson
lgtm
3 years, 10 months ago (2017-02-21 14:57:59 UTC) #3
brandtr
+sprang as owner
3 years, 10 months ago (2017-02-22 07:48:38 UTC) #5
brandtr
Rebase.
3 years, 10 months ago (2017-02-22 09:51:43 UTC) #6
brandtr
Rebase.
3 years, 10 months ago (2017-02-22 12:16:02 UTC) #7
sprang_webrtc
lgtm with nit https://codereview.webrtc.org/2703333004/diff/60001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h (right): https://codereview.webrtc.org/2703333004/diff/60001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h#newcode80 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:80: float packet_loss; packet_loss_perecent? or fraction?
3 years, 10 months ago (2017-02-22 16:39:31 UTC) #8
brandtr
https://codereview.webrtc.org/2703333004/diff/60001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h (right): https://codereview.webrtc.org/2703333004/diff/60001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h#newcode80 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:80: float packet_loss; On 2017/02/22 16:39:31, språng wrote: > packet_loss_perecent? ...
3 years, 10 months ago (2017-02-23 08:16:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2703333004/80001
3 years, 10 months ago (2017-02-23 08:17:20 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 10:49:20 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/1e46434e7ef90da1aebaf28cb...

Powered by Google App Engine
This is Rietveld 408576698