Step #0: Minor cleanups in VideoProcessor.

Minor cleanups in VideoProcessor.

This CL is broken out from a future "real" CL, that introduces
support for pipelining HW codecs to VideoProcessor. I order to
simplify the reviewing of that CL a bit, some of the cleanups are
split out here.

No functional changes are intended.

BUG=webrtc::6634

Review-Url: https://codereview.webrtc.org/2709123004
Cr-Commit-Position: refs/heads/master@{#16909}
Committed: https://chromium.googlesource.com/external/webrtc/+/aebc61e3dcf9c21bc97c07e1abd03069dd462716

[brandtr, 2017-02-23 09:02:57]

brandtr@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[brandtr, 2017-02-23 13:31:28]

Rebase.

[brandtr, 2017-02-23 14:09:33]

brandtr@webrtc.org changed reviewers:
+ sprang@webrtc.org

[brandtr, 2017-02-23 14:09:34]

Step #0 in a line of HW codec CLs :)

[brandtr, 2017-02-23 15:08:37]

Description was changed from

==========
Minor cleanups in VideoProcessor.

This CL is broken out from a future "real" CL, that introduces
support for pipelining HW codecs to VideoProcessor. I order to
simplify the reviewing of that CL a bit, some of the cleanups are
split out here.

No functional changes are intended.

BUG=webrtc::6634
==========

to

==========
Minor cleanups in VideoProcessor.

This CL is broken out from a future "real" CL, that introduces
support for pipelining HW codecs to VideoProcessor. I order to
simplify the reviewing of that CL a bit, some of the cleanups are
split out here.

No functional changes are intended.

BUG=webrtc::6634
==========

[åsapersson, 2017-02-24 08:27:07]

lgtm

https://codereview.webrtc.org/2709123004/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor.cc (right):

https://codereview.webrtc.org/2709123004/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor.cc:42: return
VideoCodecInitializer::CreateBitrateAllocator(*config.codec_settings,
return
std::unique_ptr<VideoBitrateAllocator>(VideoCodecInitializer::CreateBitrateAllocator(...));

[sprang_webrtc, 2017-02-28 09:07:23]

lgtm with åsas nit fixed

[sprang_webrtc, 2017-02-28 09:07:23]

lgtm with åsas nit fixed

[brandtr, 2017-02-28 13:59:54]

https://codereview.webrtc.org/2709123004/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor.cc (right):

https://codereview.webrtc.org/2709123004/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor.cc:42: return
VideoCodecInitializer::CreateBitrateAllocator(*config.codec_settings,
On 2017/02/24 08:27:07, åsapersson wrote:
> return
>
std::unique_ptr<VideoBitrateAllocator>(VideoCodecInitializer::CreateBitrateAllocator(...));
> 

Done.

[brandtr, 2017-02-28 14:00:15]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2017-02-28 14:00:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org, sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2709123004/#ps40001 (title:
"asapersson comments 1")

[commit-bot: I haz the power, 2017-02-28 14:00:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-28 14:21:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 14:21:34]

Try jobs failed on following builders:
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/23233)

[brandtr, 2017-02-28 14:36:05]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2017-02-28 14:36:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-28 15:13:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488292565379860,
"parent_rev": "b61927c6879a21cd9b8085f3899fb1239458e969", "commit_rev":
"aebc61e3dcf9c21bc97c07e1abd03069dd462716"}

[commit-bot: I haz the power, 2017-02-28 15:13:50]

Description was changed from

==========
Minor cleanups in VideoProcessor.

This CL is broken out from a future "real" CL, that introduces
support for pipelining HW codecs to VideoProcessor. I order to
simplify the reviewing of that CL a bit, some of the cleanups are
split out here.

No functional changes are intended.

BUG=webrtc::6634
==========

to

==========
Minor cleanups in VideoProcessor.

This CL is broken out from a future "real" CL, that introduces
support for pipelining HW codecs to VideoProcessor. I order to
simplify the reviewing of that CL a bit, some of the cleanups are
split out here.

No functional changes are intended.

BUG=webrtc::6634

Review-Url: https://codereview.webrtc.org/2709123004
Cr-Commit-Position: refs/heads/master@{#16909}
Committed:
https://chromium.googlesource.com/external/webrtc/+/aebc61e3dcf9c21bc97c07e1a...
==========

[commit-bot: I haz the power, 2017-02-28 15:13:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/aebc61e3dcf9c21bc97c07e1a...