Reland of Delete class SSRCDatabase, and its global ssrc registry.

Reland of Delete class SSRCDatabase, and its global ssrc registry. (patchset #1 id:1 of https://codereview.webrtc.org/2700413002/ )

Reason for revert:
Intend to fix perf problem and reland.

Original issue's description:
> Revert of Delete class SSRCDatabase, and its global ssrc registry. (patchset #20 id:370001 of https://codereview.webrtc.org/2644303002/ )
> 
> Reason for revert:
> Breaks webrtc_perf_tests reliably:
> https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28L%20Nexus5%29/builds/1780
> https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28L%20Nexus4%29/builds/178
> 
> We're actively working on getting a quick version of webrtc_perf_tests up on the trybots again to prevent breakages like this: https://bugs.chromium.org/p/webrtc/issues/detail?id=7101
> 
> Original issue's description:
> > Delete class SSRCDatabase, and its global ssrc registry, 
> > and the method RTPSender::GenerateNewSSRC.
> > 
> > It's now mandatory for higher layers to call SetSSRC, RTPSender 
> > no longer allocates any ssrc by default.
> > 
> > BUG=webrtc:4306, webrtc:6887
> > 
> > Review-Url: https://codereview.webrtc.org/2644303002
> > Cr-Commit-Position: refs/heads/master@{#16670}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/b78d4d13835f628e722a57abae2bf06ba3655921
> 
> TBR=solenberg@webrtc.org,stefan@webrtc.org,danilchap@webrtc.org,ivoc@webrtc.org,nisse@webrtc.org
> NOTRY=True
> BUG=webrtc:4306, webrtc:6887
> 
> Review-Url: https://codereview.webrtc.org/2700413002
> Cr-Commit-Position: refs/heads/master@{#16693}
> Committed: https://chromium.googlesource.com/external/webrtc/+/b5848ecbf5f7b310108546ec6b858fe93452f58e

TBR=solenberg@webrtc.org,stefan@webrtc.org,danilchap@webrtc.org,ivoc@webrtc.org,kjellander@webrtc.org,kjellander@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:4306, webrtc:6887
Review-Url: https://codereview.webrtc.org/2702203002
Cr-Commit-Position: refs/heads/master@{#16737}
Committed: https://chromium.googlesource.com/external/webrtc/+/7d59f6b1c46cf551d2b55849ed061756ba25f1b0

[nisse-webrtc, 2017-02-20 08:14:58]

Created Reland of Delete class SSRCDatabase, and its global ssrc registry.

[nisse-webrtc, 2017-02-20 14:05:26]

Patchset #2 (id:230001) has been deleted

[nisse-webrtc, 2017-02-20 14:12:53]

The problem was that the RtpRtcp receiver was configured before Rtx, and then
feedback messages for the Rtx ssrc weren't processed.

It used to work because there were a call to SetRtcpReceiverSsrcs from 
ModuleRtpRtcpImpl::SetSendingStatus, with a comment claiming it was only for the
collision case.

Fix verified by running 

  webrtc_perf_tests  --gtest_filter='RampUpTest.*'

locally. It's a bit scary that these rampup tests were the only tests failing
after a severe misconfiguration of the rtcp receiver.

[danilchap, 2017-02-20 14:55:38]

lgtm

[nisse-webrtc, 2017-02-20 14:57:12]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-02-20 14:57:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ivoc, 2017-02-20 15:02:19]

On 2017/02/20 14:12:53, nisse-webrtc wrote:
> The problem was that the RtpRtcp receiver was configured before Rtx, and then
> feedback messages for the Rtx ssrc weren't processed.
> 
> It used to work because there were a call to SetRtcpReceiverSsrcs from 
> ModuleRtpRtcpImpl::SetSendingStatus, with a comment claiming it was only for
the
> collision case.
> 
> Fix verified by running 
> 
>   webrtc_perf_tests  --gtest_filter='RampUpTest.*'
> 
> locally. It's a bit scary that these rampup tests were the only tests failing
> after a severe misconfiguration of the rtcp receiver.

Perhaps it's a good opportunity to add some tests that would catch issues like
this?

[commit-bot: I haz the power, 2017-02-20 15:13:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 15:13:58]

Try jobs failed on following builders:
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/22883)

[nisse-webrtc, 2017-02-20 15:27:52]

On 2017/02/20 14:12:53, nisse-webrtc wrote:
> The problem was that the RtpRtcp receiver was configured before Rtx, and then
> feedback messages for the Rtx ssrc weren't processed.
> 
> It used to work because there were a call to SetRtcpReceiverSsrcs from 
> ModuleRtpRtcpImpl::SetSendingStatus, with a comment claiming it was only for
the
> collision case.
> 
> Fix verified by running 
> 
>   webrtc_perf_tests  --gtest_filter='RampUpTest.*'
> 
> locally. It's a bit scary that these rampup tests were the only tests failing
> after a severe misconfiguration of the rtcp receiver.

The change in ps #3 implies a stricter requirements on method call order. One
must call SetSsrc before calling SetRtxSendStatus or SetRtxSsrc. And if calling
SetRtxSendStatus with non-zero argument, one must call SetRtxSsrc first.

Those requirements aren't totally unreasonable, but I don't want to make them in
this cl. So I'm going to move the SetRtcpReceiverSsrcs call back to
SetSendingStatus.

[nisse-webrtc, 2017-02-21 07:25:20]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2017-02-21 07:25:20]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2702203002/#ps290001 (title:
"Move SetRtcpReceiverSsrcs call to ModuleRtpRtcpImpl::SetSendingStatus. Update
tests to set SSRC ear…")

[commit-bot: I haz the power, 2017-02-21 07:25:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-21 09:44:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 09:44:22]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/21585)

[nisse-webrtc, 2017-02-21 09:49:15]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-02-21 09:49:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-21 11:40:25]

CQ is committing da patch.

Bot data: {"patchset_id": 290001, "attempt_start_ts": 1487670555742050,
"parent_rev": "531100dc7a9c58d8cbe200cf3a65d1254070861d", "commit_rev":
"7d59f6b1c46cf551d2b55849ed061756ba25f1b0"}

[commit-bot: I haz the power, 2017-02-21 11:40:28]

Description was changed from

==========
Reland of Delete class SSRCDatabase, and its global ssrc registry. (patchset #1
id:1 of https://codereview.webrtc.org/2700413002/ )

Reason for revert:
Intend to fix perf problem and reland.

Original issue's description:
> Revert of Delete class SSRCDatabase, and its global ssrc registry. (patchset
#20 id:370001 of https://codereview.webrtc.org/2644303002/ )
> 
> Reason for revert:
> Breaks webrtc_perf_tests reliably:
>
https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20...
>
https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20...
> 
> We're actively working on getting a quick version of webrtc_perf_tests up on
the trybots again to prevent breakages like this:
https://bugs.chromium.org/p/webrtc/issues/detail?id=7101
> 
> Original issue's description:
> > Delete class SSRCDatabase, and its global ssrc registry, 
> > and the method RTPSender::GenerateNewSSRC.
> > 
> > It's now mandatory for higher layers to call SetSSRC, RTPSender 
> > no longer allocates any ssrc by default.
> > 
> > BUG=webrtc:4306,webrtc:6887
> > 
> > Review-Url: https://codereview.webrtc.org/2644303002
> > Cr-Commit-Position: refs/heads/master@{#16670}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/b78d4d13835f628e722a57aba...
> 
>
TBR=solenberg@webrtc.org,stefan@webrtc.org,danilchap@webrtc.org,ivoc@webrtc.o...
> NOTRY=True
> BUG=webrtc:4306,webrtc:6887
> 
> Review-Url: https://codereview.webrtc.org/2700413002
> Cr-Commit-Position: refs/heads/master@{#16693}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/b5848ecbf5f7b310108546ec6...

TBR=solenberg@webrtc.org,stefan@webrtc.org,danilchap@webrtc.org,ivoc@webrtc.o...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:4306,webrtc:6887
==========

to

==========
Reland of Delete class SSRCDatabase, and its global ssrc registry. (patchset #1
id:1 of https://codereview.webrtc.org/2700413002/ )

Reason for revert:
Intend to fix perf problem and reland.

Original issue's description:
> Revert of Delete class SSRCDatabase, and its global ssrc registry. (patchset
#20 id:370001 of https://codereview.webrtc.org/2644303002/ )
> 
> Reason for revert:
> Breaks webrtc_perf_tests reliably:
>
https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20...
>
https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20...
> 
> We're actively working on getting a quick version of webrtc_perf_tests up on
the trybots again to prevent breakages like this:
https://bugs.chromium.org/p/webrtc/issues/detail?id=7101
> 
> Original issue's description:
> > Delete class SSRCDatabase, and its global ssrc registry, 
> > and the method RTPSender::GenerateNewSSRC.
> > 
> > It's now mandatory for higher layers to call SetSSRC, RTPSender 
> > no longer allocates any ssrc by default.
> > 
> > BUG=webrtc:4306,webrtc:6887
> > 
> > Review-Url: https://codereview.webrtc.org/2644303002
> > Cr-Commit-Position: refs/heads/master@{#16670}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/b78d4d13835f628e722a57aba...
> 
>
TBR=solenberg@webrtc.org,stefan@webrtc.org,danilchap@webrtc.org,ivoc@webrtc.o...
> NOTRY=True
> BUG=webrtc:4306,webrtc:6887
> 
> Review-Url: https://codereview.webrtc.org/2700413002
> Cr-Commit-Position: refs/heads/master@{#16693}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/b5848ecbf5f7b310108546ec6...

TBR=solenberg@webrtc.org,stefan@webrtc.org,danilchap@webrtc.org,ivoc@webrtc.o...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:4306,webrtc:6887

Review-Url: https://codereview.webrtc.org/2702203002
Cr-Commit-Position: refs/heads/master@{#16737}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7d59f6b1c46cf551d2b55849e...
==========

[commit-bot: I haz the power, 2017-02-21 11:40:29]

Committed patchset #4 (id:290001) as
https://chromium.googlesource.com/external/webrtc/+/7d59f6b1c46cf551d2b55849e...