Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2700413002: Revert of Delete class SSRCDatabase, and its global ssrc registry. (Closed)

Created:
3 years, 10 months ago by kjellander (google.com)
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman, tomasl_google.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete class SSRCDatabase, and its global ssrc registry. (patchset #20 id:370001 of https://codereview.webrtc.org/2644303002/ ) Reason for revert: Breaks webrtc_perf_tests reliably: https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28L%20Nexus5%29/builds/1780 https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28L%20Nexus4%29/builds/178 We're actively working on getting a quick version of webrtc_perf_tests up on the trybots again to prevent breakages like this: https://bugs.chromium.org/p/webrtc/issues/detail?id=7101 Original issue's description: > Delete class SSRCDatabase, and its global ssrc registry, > and the method RTPSender::GenerateNewSSRC. > > It's now mandatory for higher layers to call SetSSRC, RTPSender > no longer allocates any ssrc by default. > > BUG=webrtc:4306, webrtc:6887 > > Review-Url: https://codereview.webrtc.org/2644303002 > Cr-Commit-Position: refs/heads/master@{#16670} > Committed: https://chromium.googlesource.com/external/webrtc/+/b78d4d13835f628e722a57abae2bf06ba3655921 TBR=solenberg@webrtc.org,stefan@webrtc.org,danilchap@webrtc.org,ivoc@webrtc.org,nisse@webrtc.org NOTRY=True BUG=webrtc:4306, webrtc:6887 Review-Url: https://codereview.webrtc.org/2700413002 Cr-Commit-Position: refs/heads/master@{#16693} Committed: https://chromium.googlesource.com/external/webrtc/+/b5848ecbf5f7b310108546ec6b858fe93452f58e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -71 lines) Patch
M webrtc/logging/rtc_event_log/rtc_event_log.proto View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 4 chunks +37 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 5 chunks +8 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 21 chunks +63 lines, -41 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 7 chunks +1 line, -7 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/ssrc_database.h View 1 chunk +62 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/ssrc_database.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel_manager.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/voice_engine/channel_manager.cc View 2 chunks +1 line, -8 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/standard/rtp_rtcp_test.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kjellander (google.com)
Created Revert of Delete class SSRCDatabase, and its global ssrc registry.
3 years, 10 months ago (2017-02-18 19:50:12 UTC) #1
kjellander_webrtc
lgtm
3 years, 10 months ago (2017-02-18 19:51:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2700413002/1
3 years, 10 months ago (2017-02-18 19:58:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/b5848ecbf5f7b310108546ec6b858fe93452f58e
3 years, 10 months ago (2017-02-18 20:00:54 UTC) #9
kjellander_webrtc
On 2017/02/18 20:00:54, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 10 months ago (2017-02-18 20:59:25 UTC) #10
nisse-webrtc
3 years, 10 months ago (2017-02-20 08:14:57 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2702203002/ by nisse@webrtc.org.

The reason for reverting is: Intend to fix perf problem and reland..

Powered by Google App Engine
This is Rietveld 408576698