Remove the Windows Wave audio device implementation.

Remove the Windows Wave audio device implementation.
This implementation uses various legacy classes such as EventTimeWrapper,
CriticalSectionWrapper, EventWrapper etc and hasn't been maintained
(or used?) for a long time.

Instead of spending time on testing and updating the class, I think
we should just remove it. For versions of Windows that we support,
following Win7, we use the CoreAudio implementation.

BUG=webrtc:7183
R=solenberg@webrtc.org

Review-Url: https://codereview.webrtc.org/2700983002 .
Cr-Commit-Position: refs/heads/master@{#16678}
Committed: https://chromium.googlesource.com/external/webrtc/+/cc8588c0400df7c03f305da0a96c32bae3b5b2fa

[tommi, 2017-02-17 16:57:29]

tommi@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[tommi, 2017-02-17 16:57:35]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 16:57:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-17 17:00:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 17:00:28]

Dry run: Try jobs failed on following builders:
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/22908)
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/13640)

[the sun, 2017-02-17 17:20:18]

On 2017/02/17 16:57:29, tommi (webrtc) wrote:

Good call! I'm happy to take a closer look once you've convinced a few more of
the bots. :)

[tommi, 2017-02-17 18:09:48]

On 2017/02/17 17:20:18, the sun wrote:
> On 2017/02/17 16:57:29, tommi (webrtc) wrote:
> 
> Good call! I'm happy to take a closer look once you've convinced a few more of
> the bots. :)

wow, they really look embarrassed :-|

[tommi, 2017-02-17 18:14:51]

Remove kAudioWindowsWave (silly me only removing kWindowsWaveAudio).

[tommi, 2017-02-17 18:15:00]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 18:15:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-17 18:19:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 18:19:51]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/13642)

[the sun, 2017-02-17 18:34:26]

On 2017/02/17 18:14:51, tommi (webrtc) wrote:
> Remove kAudioWindowsWave (silly me only removing kWindowsWaveAudio).

It looks like audio_mixer_manager_win.* can be removed also. AFAICT it is only
used in the Wave impl.

[the sun, 2017-02-17 18:41:55]

lgtm % comments

https://codereview.webrtc.org/2700983002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/audio_device_impl.cc (right):

https://codereview.webrtc.org/2700983002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/audio_device_impl.cc:202: #if defined(_WIN32)
Can we remove the _WIN32 conditional?

https://codereview.webrtc.org/2700983002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/test/audio_device_test_api.cc (right):

https://codereview.webrtc.org/2700983002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/test/audio_device_test_api.cc:173: kId,
AudioDeviceModule::kLinuxAlsaAudio)) == NULL);
Should this go in the #else part instead? And remove the _WIN32 conditional.

In non-platform-specific code we should only use our own compiler flags.

[tommi, 2017-02-17 21:43:34]

Delete even more code and clean up _WIN32 usage

[tommi, 2017-02-17 21:43:42]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 21:43:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[tommi, 2017-02-17 21:44:22]

https://codereview.webrtc.org/2700983002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/audio_device_impl.cc (right):

https://codereview.webrtc.org/2700983002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/audio_device_impl.cc:202: #if defined(_WIN32)
On 2017/02/17 18:41:55, the sun wrote:
> Can we remove the _WIN32 conditional?

Done.

https://codereview.webrtc.org/2700983002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/test/audio_device_test_api.cc (right):

https://codereview.webrtc.org/2700983002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/test/audio_device_test_api.cc:173: kId,
AudioDeviceModule::kLinuxAlsaAudio)) == NULL);
On 2017/02/17 18:41:55, the sun wrote:
> Should this go in the #else part instead? And remove the _WIN32 conditional.
> 
> In non-platform-specific code we should only use our own compiler flags.

Oddly, this is to test that creating an instance of the linux alsa audio module,
fails on Windows :-/ The code is structured differently than we're used to. I
think that if we were writing this now, the kLinuxAlsaAudio constant wouldn't
even be defined when building for Windows.

However, to get rid of the _WIN32 conditional, I'll just remove this test. It's
kinda pointless anyway. So, Done.

[tommi, 2017-02-17 21:44:46]

https://codereview.webrtc.org/2700983002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/test/audio_device_test_api.cc (right):

https://codereview.webrtc.org/2700983002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/test/audio_device_test_api.cc:173: kId,
AudioDeviceModule::kLinuxAlsaAudio)) == NULL);
On 2017/02/17 21:44:22, tommi (webrtc) wrote:
> On 2017/02/17 18:41:55, the sun wrote:
> > Should this go in the #else part instead? And remove the _WIN32 conditional.
> > 
> > In non-platform-specific code we should only use our own compiler flags.
> 
> Oddly, this is to test that creating an instance of the linux alsa audio
module,
> fails on Windows :-/ The code is structured differently than we're used to. I
> think that if we were writing this now, the kLinuxAlsaAudio constant wouldn't
> even be defined when building for Windows.
> 
> However, to get rid of the _WIN32 conditional, I'll just remove this test.
It's
> kinda pointless anyway. So, Done.

and by 'test', I mean expectation.

[commit-bot: I haz the power, 2017-02-17 21:48:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 21:48:42]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/13655)

[tommi, 2017-02-17 22:37:14]

Description was changed from

==========
Remove the Windows Wave audio device implementation.
This implementation uses various legacy classes such as EventTimeWrapper,
CriticalSectionWrapper, EventWrapper etc and hasn't been maintained
(or used?) for a long time.

Instead of spending time on testing and updating the class, I think
we should just remove it. For versions of Windows that we support,
following Win7, we use the CoreAudio implementation.

BUG=
==========

to

==========
Remove the Windows Wave audio device implementation.
This implementation uses various legacy classes such as EventTimeWrapper,
CriticalSectionWrapper, EventWrapper etc and hasn't been maintained
(or used?) for a long time.

Instead of spending time on testing and updating the class, I think
we should just remove it. For versions of Windows that we support,
following Win7, we use the CoreAudio implementation.

BUG=7183
==========

[tommi, 2017-02-17 22:37:29]

Description was changed from

==========
Remove the Windows Wave audio device implementation.
This implementation uses various legacy classes such as EventTimeWrapper,
CriticalSectionWrapper, EventWrapper etc and hasn't been maintained
(or used?) for a long time.

Instead of spending time on testing and updating the class, I think
we should just remove it. For versions of Windows that we support,
following Win7, we use the CoreAudio implementation.

BUG=7183
==========

to

==========
Remove the Windows Wave audio device implementation.
This implementation uses various legacy classes such as EventTimeWrapper,
CriticalSectionWrapper, EventWrapper etc and hasn't been maintained
(or used?) for a long time.

Instead of spending time on testing and updating the class, I think
we should just remove it. For versions of Windows that we support,
following Win7, we use the CoreAudio implementation.

BUG=webrtc:7183
==========

[tommi, 2017-02-17 22:48:46]

Description was changed from

==========
Remove the Windows Wave audio device implementation.
This implementation uses various legacy classes such as EventTimeWrapper,
CriticalSectionWrapper, EventWrapper etc and hasn't been maintained
(or used?) for a long time.

Instead of spending time on testing and updating the class, I think
we should just remove it. For versions of Windows that we support,
following Win7, we use the CoreAudio implementation.

BUG=webrtc:7183
==========

to

==========
Remove the Windows Wave audio device implementation.
This implementation uses various legacy classes such as EventTimeWrapper,
CriticalSectionWrapper, EventWrapper etc and hasn't been maintained
(or used?) for a long time.

Instead of spending time on testing and updating the class, I think
we should just remove it. For versions of Windows that we support,
following Win7, we use the CoreAudio implementation.

BUG=webrtc:7183
R=solenberg@webrtc.org

Review-Url: https://codereview.webrtc.org/2700983002 .
Cr-Commit-Position: refs/heads/master@{#16678}
Committed:
https://chromium.googlesource.com/external/webrtc/+/cc8588c0400df7c03f305da0a...
==========

[tommi, 2017-02-17 22:48:48]

Committed patchset #3 (id:40001) manually as
cc8588c0400df7c03f305da0a96c32bae3b5b2fa (presubmit successful).

[henrika_webrtc, 2017-02-20 08:15:09]

Thanks. lgtm