iSAC float decoder: Don't read past end of initialized part of buffer

iSAC float decoder: Don't read past end of initialized part of buffer

This is a backport to M57 of this CL: https://codereview.webrtc.org/2659383002

We read past the end of the initialized part of the buffer, seemingly
on purpose (no one knows the details of this code anymore). The right
thing to do is probably to zero that part of the buffer.

(The *right* right thing to would be to rewrite this so that it was
easier to see what data was supposed to be where when, but
priorities...)

NOTRY=true
NOPRESUBMIT=true
BUG=chromium:683040
Review-Url: https://codereview.webrtc.org/2697683003
Cr-Commit-Position: refs/branch-heads/57@{#5}
Cr-Branched-From: e5cbc2019003dbb40e03811d7607feb95757a4ec-refs/heads/master@{#16123}
Committed: https://chromium.googlesource.com/external/webrtc/+/c70bda046642a9c7288fc79bb4d26f67c5b1aacb

[kwiberg-webrtc, 2017-02-14 13:31:15]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 13:31:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-14 13:31:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 13:31:20]

Dry run: CLs for remote refs other than refs/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[kwiberg-webrtc, 2017-02-14 13:32:22]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2017-02-14 13:35:49]

lgtm

[kwiberg-webrtc, 2017-02-14 13:41:38]

Description was changed from

==========
iSAC float decoder: Don't read past end of initialized part of buffer

This is a backport to M57 of this CL: https://codereview.webrtc.org/2659383002

We read past the end of the initialized part of the buffer, seemingly
on purpose (no one knows the details of this code anymore). The right
thing to do is probably to zero that part of the buffer.

(The *right* right thing to would be to rewrite this so that it was
easier to see what data was supposed to be where when, but
priorities...)

BUG=chromium:683040
==========

to

==========
iSAC float decoder: Don't read past end of initialized part of buffer

This is a backport to M57 of this CL: https://codereview.webrtc.org/2659383002

We read past the end of the initialized part of the buffer, seemingly
on purpose (no one knows the details of this code anymore). The right
thing to do is probably to zero that part of the buffer.

(The *right* right thing to would be to rewrite this so that it was
easier to see what data was supposed to be where when, but
priorities...)

NOTRY=true
NOPRESUBMIT=true
BUG=chromium:683040
==========

[kwiberg-webrtc, 2017-02-14 13:41:45]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-02-14 13:41:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-14 13:41:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487079705649160, "parent_rev":
"76ad439d6c00e2f3ee62e417390541616522a35e", "commit_rev":
"c70bda046642a9c7288fc79bb4d26f67c5b1aacb"}

[commit-bot: I haz the power, 2017-02-14 13:41:58]

Description was changed from

==========
iSAC float decoder: Don't read past end of initialized part of buffer

This is a backport to M57 of this CL: https://codereview.webrtc.org/2659383002

We read past the end of the initialized part of the buffer, seemingly
on purpose (no one knows the details of this code anymore). The right
thing to do is probably to zero that part of the buffer.

(The *right* right thing to would be to rewrite this so that it was
easier to see what data was supposed to be where when, but
priorities...)

NOTRY=true
NOPRESUBMIT=true
BUG=chromium:683040
==========

to

==========
iSAC float decoder: Don't read past end of initialized part of buffer

This is a backport to M57 of this CL: https://codereview.webrtc.org/2659383002

We read past the end of the initialized part of the buffer, seemingly
on purpose (no one knows the details of this code anymore). The right
thing to do is probably to zero that part of the buffer.

(The *right* right thing to would be to rewrite this so that it was
easier to see what data was supposed to be where when, but
priorities...)

NOTRY=true
NOPRESUBMIT=true
BUG=chromium:683040

Review-Url: https://codereview.webrtc.org/2697683003
Cr-Commit-Position: refs/branch-heads/57@{#5}
Cr-Branched-From:
e5cbc2019003dbb40e03811d7607feb95757a4ec-refs/heads/master@{#16123}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c70bda046642a9c7288fc79bb...
==========

[commit-bot: I haz the power, 2017-02-14 13:41:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c70bda046642a9c7288fc79bb...