iSAC float decoder: Don't read past end of initialized part of buffer

iSAC float decoder: Don't read past end of initialized part of buffer

We read past the end of the initialized part of the buffer, seemingly
on purpose (no one knows the details of this code anymore). The right
thing to do is probably to zero that part of the buffer.

(The *right* right thing to would be to rewrite this so that it was
easier to see what data was supposed to be where when, but
priorities...)

BUG=chromium:683040
Review-Url: https://codereview.webrtc.org/2659383002
Cr-Commit-Position: refs/heads/master@{#16365}
Committed: https://chromium.googlesource.com/external/webrtc/+/c14b7ed479b8efb38ca04ea536272bd7a2d4f0ff

[kwiberg-webrtc, 2017-01-30 14:19:14]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 14:19:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-01-30 14:20:45]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, tina.legrand@webrtc.org

[kwiberg-webrtc, 2017-01-30 14:20:46]

Please double-check the arithmetic carefully for me, would you?

[hlundin-webrtc, 2017-01-30 14:53:57]

lgtm

[commit-bot: I haz the power, 2017-01-30 15:00:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 15:00:55]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-01-30 19:38:22]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2017-01-30 19:38:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2659383002/#ps20001 (title:
"Use a compile-time check, because we can!")

[commit-bot: I haz the power, 2017-01-30 19:38:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-30 20:17:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485805102752740,
"parent_rev": "ba3f4111ffbe31cc27263924a3701db2e7ed030d", "commit_rev":
"c14b7ed479b8efb38ca04ea536272bd7a2d4f0ff"}

[commit-bot: I haz the power, 2017-01-30 20:17:08]

Description was changed from

==========
iSAC float decoder: Don't read past end of initialized part of buffer

We read past the end of the initialized part of the buffer, seemingly
on purpose (no one knows the details of this code anymore). The right
thing to do is probably to zero that part of the buffer.

(The *right* right thing to would be to rewrite this so that it was
easier to see what data was supposed to be where when, but
priorities...)

BUG=chromium:683040
==========

to

==========
iSAC float decoder: Don't read past end of initialized part of buffer

We read past the end of the initialized part of the buffer, seemingly
on purpose (no one knows the details of this code anymore). The right
thing to do is probably to zero that part of the buffer.

(The *right* right thing to would be to rewrite this so that it was
easier to see what data was supposed to be where when, but
priorities...)

BUG=chromium:683040

Review-Url: https://codereview.webrtc.org/2659383002
Cr-Commit-Position: refs/heads/master@{#16365}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c14b7ed479b8efb38ca04ea53...
==========

[commit-bot: I haz the power, 2017-01-30 20:17:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/c14b7ed479b8efb38ca04ea53...