Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2697583002: Style fixes: VideoProcessor and corresponding integration test. (Closed)

Created:
3 years, 10 months ago by brandtr
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Style fixes: VideoProcessor and corresponding integration test. This CL has no intended functional changes. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2697583002 Cr-Commit-Position: refs/heads/master@{#16628} Committed: https://chromium.googlesource.com/external/webrtc/+/8bc9385fcbeea589cbac577d2c15e7e1632c57b8

Patch Set 1 #

Patch Set 2 : Fix compile for plot_videoprocessor_integrationtest.cc #

Total comments: 4

Patch Set 3 : asapersson comments 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -182 lines) Patch
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 5 chunks +63 lines, -44 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 12 chunks +44 lines, -56 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 2 9 chunks +57 lines, -54 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 13 chunks +26 lines, -26 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
brandtr
3 years, 10 months ago (2017-02-13 16:25:14 UTC) #6
åsapersson
lgtm https://codereview.webrtc.org/2697583002/diff/60001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h (right): https://codereview.webrtc.org/2697583002/diff/60001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h#newcode196 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:196: RTC_DCHECK(frame_reader_->Init()); maybe RTC_CHECK https://codereview.webrtc.org/2697583002/diff/60001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h#newcode204 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:204: RTC_DCHECK(processor_->Init()); ditto
3 years, 10 months ago (2017-02-15 08:51:35 UTC) #7
brandtr
https://codereview.webrtc.org/2697583002/diff/60001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h (right): https://codereview.webrtc.org/2697583002/diff/60001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h#newcode196 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:196: RTC_DCHECK(frame_reader_->Init()); On 2017/02/15 08:51:34, åsapersson wrote: > maybe RTC_CHECK ...
3 years, 10 months ago (2017-02-15 08:57:13 UTC) #8
sprang_webrtc
lgtm
3 years, 10 months ago (2017-02-15 10:53:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2697583002/80001
3 years, 10 months ago (2017-02-15 12:05:52 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 13:19:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/8bc9385fcbeea589cbac577d2...

Powered by Google App Engine
This is Rietveld 408576698