Tighten up encode time measurement in VideoProcessor.

Tighten up encode time measurement in VideoProcessor.

No point in measuring the time needed to write dropped frames to disk.

BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2696503003
Cr-Commit-Position: refs/heads/master@{#16629}
Committed: https://chromium.googlesource.com/external/webrtc/+/32e0d26096e8bf5b2652211a464843914b7fc6db

[brandtr, 2017-02-13 16:25:15]

brandtr@webrtc.org changed reviewers:
+ asapersson@webrtc.org, sprang@webrtc.org

[åsapersson, 2017-02-14 09:14:41]

lgtm

[brandtr, 2017-02-15 08:13:26]

Rebase.

[brandtr, 2017-02-15 08:57:32]

Rebase.

[sprang_webrtc, 2017-02-15 10:50:59]

lgtm with nit

https://codereview.webrtc.org/2696503003/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor.cc (right):

https://codereview.webrtc.org/2696503003/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor.cc:255: int64_t
encode_stop_ns = rtc::TimeNanos();
Maybe add comments clarifying that timestamps should be captured as close to the
start/end of encoding as possible, so that someone won't accidentally move them
close to where they're used instead, in a misguided effort to prettify the code?

[brandtr, 2017-02-15 12:12:48]

Patchset #4 (id:60001) has been deleted

[brandtr, 2017-02-15 12:13:36]

https://codereview.webrtc.org/2696503003/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor.cc (right):

https://codereview.webrtc.org/2696503003/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor.cc:255: int64_t
encode_stop_ns = rtc::TimeNanos();
On 2017/02/15 10:50:59, språng wrote:
> Maybe add comments clarifying that timestamps should be captured as close to
the
> start/end of encoding as possible, so that someone won't accidentally move
them
> close to where they're used instead, in a misguided effort to prettify the
code?

Good idea. Done.

[brandtr, 2017-02-15 12:13:40]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 12:13:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-15 13:26:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 13:26:07]

Dry run: This issue passed the CQ dry run.

[brandtr, 2017-02-15 13:26:35]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2017-02-15 13:26:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org, sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2696503003/#ps80001 (title:
"sprang comments 1.")

[commit-bot: I haz the power, 2017-02-15 13:26:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-15 13:29:39]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487165195799720,
"parent_rev": "8bc9385fcbeea589cbac577d2c15e7e1632c57b8", "commit_rev":
"32e0d26096e8bf5b2652211a464843914b7fc6db"}

[commit-bot: I haz the power, 2017-02-15 13:29:41]

Description was changed from

==========
Tighten up encode time measurement in VideoProcessor.

No point in measuring the time needed to write dropped frames to disk.

BUG=webrtc:6634
==========

to

==========
Tighten up encode time measurement in VideoProcessor.

No point in measuring the time needed to write dropped frames to disk.

BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/2696503003
Cr-Commit-Position: refs/heads/master@{#16629}
Committed:
https://chromium.googlesource.com/external/webrtc/+/32e0d26096e8bf5b2652211a4...
==========

[commit-bot: I haz the power, 2017-02-15 13:29:42]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/32e0d26096e8bf5b2652211a4...