Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2697133002: Reland of iOS: Use JSON for GN configuration instead of MB + remove symbols (Closed)

Created:
3 years, 10 months ago by kjellander_webrtc
Modified:
3 years, 10 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of iOS: Use JSON for GN configuration instead of MB + remove symbols Reason for revert: MB is now updated to handle spaces in the buildername properly, something that only affected our commit bots (not trybots). Original issue's description: > Revert of iOS: Use JSON for GN configuration instead of MB + remove symbols (patchset #4 id:80001 of https://codereview.webrtc.org/2688103002/ ) > > Reason for revert: > Something is different from trybots vs the commit bots, causing it to fail when running GN: > https://build.chromium.org/p/client.webrtc/builders/iOS32%20Release/builds/10151 > > Original issue's description: > > iOS: Use JSON for GN configuration instead of MB + remove symbols. > > > > This aligns with how the ios recipe module is used in Chromium. > > It should prevent breakages like one we had recently. > > > > It also means we're no longer setting symbol_level=1 explicitly. > > The default is 0 (no symbols), which is now what's being used. > > > > Also move all the directories containing JSON files into > > tools-webrtc/ios/bots to make it clearer (and more similar to > > Chromium). > > > > BUG=webrtc:7140, webrtc:7161 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2688103002 > > Cr-Commit-Position: refs/heads/master@{#16633} > > Committed: https://chromium.googlesource.com/external/webrtc/+/73f01de4edda30c419bf6daf8b91d2a0d28c06a9 > > TBR=ehmaldonado@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7140, webrtc:7161 > > Review-Url: https://codereview.webrtc.org/2694423002 > Cr-Commit-Position: refs/heads/master@{#16634} > Committed: https://chromium.googlesource.com/external/webrtc/+/68ab366547b7494b69e28047b17ad2ebd64e9edd TBR=ehmaldonado@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7140, webrtc:7161 Review-Url: https://codereview.webrtc.org/2697133002 Cr-Commit-Position: refs/heads/master@{#16636} Committed: https://chromium.googlesource.com/external/webrtc/+/1c3548c67c27063171453fc25766f600c7d498a4

Patch Set 1 #

Patch Set 2 : Fix iOS reading in MB #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -111 lines) Patch
M tools-webrtc/ios/client.webrtc/iOS32_Debug.json View 1 chunk +5 lines, -4 lines 0 comments Download
M tools-webrtc/ios/client.webrtc/iOS32_Release.json View 1 chunk +6 lines, -4 lines 0 comments Download
M tools-webrtc/ios/client.webrtc/iOS32_Sim_Debug_(iOS_9.0).json View 1 chunk +4 lines, -4 lines 0 comments Download
M tools-webrtc/ios/client.webrtc/iOS64_Debug.json View 1 chunk +5 lines, -4 lines 0 comments Download
M tools-webrtc/ios/client.webrtc/iOS64_Release.json View 1 chunk +6 lines, -4 lines 0 comments Download
M tools-webrtc/ios/client.webrtc/iOS64_Sim_Debug_(iOS_10.0).json View 1 chunk +4 lines, -4 lines 0 comments Download
M tools-webrtc/ios/client.webrtc/iOS64_Sim_Debug_(iOS_9.0).json View 1 chunk +4 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios32_sim_ios9_dbg.json View 1 chunk +4 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios64_sim_ios10_dbg.json View 1 chunk +4 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios64_sim_ios9_dbg.json View 1 chunk +4 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios_arm64_dbg.json View 1 chunk +5 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios_arm64_rel.json View 1 chunk +6 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios_dbg.json View 1 chunk +5 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios_rel.json View 1 chunk +6 lines, -4 lines 0 comments Download
M tools-webrtc/mb/mb.py View 1 8 chunks +12 lines, -11 lines 0 comments Download
M tools-webrtc/mb/mb_config.pyl View 1 6 chunks +21 lines, -42 lines 0 comments Download
M tools-webrtc/mb/mb_unittest.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
kjellander_webrtc
Created Reland of iOS: Use JSON for GN configuration instead of MB + remove symbols
3 years, 10 months ago (2017-02-15 21:05:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2697133002/260001
3 years, 10 months ago (2017-02-16 06:38:13 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 06:38:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:260001) as
https://chromium.googlesource.com/external/webrtc/+/1c3548c67c27063171453fc25...

Powered by Google App Engine
This is Rietveld 408576698