iOS: Use JSON for GN configuration instead of MB + remove symbols

iOS: Use JSON for GN configuration instead of MB + remove symbols.

This aligns with how the ios recipe module is used in Chromium.
It should prevent breakages like one we had recently.

It also means we're no longer setting symbol_level=1 explicitly. 
The default is 0 (no symbols), which is now what's being used.

Also move all the directories containing JSON files into
tools-webrtc/ios/bots to make it clearer (and more similar to
Chromium).

BUG=webrtc:7140, webrtc:7161
NOTRY=True

Review-Url: https://codereview.webrtc.org/2688103002
Cr-Commit-Position: refs/heads/master@{#16633}
Committed: https://chromium.googlesource.com/external/webrtc/+/73f01de4edda30c419bf6daf8b91d2a0d28c06a9

[kjellander_webrtc, 2017-02-10 12:14:46]

Patchset #3 (id:40001) has been deleted

[kjellander_webrtc, 2017-02-10 14:09:26]

kjellander@webrtc.org changed reviewers:
+ ehmaldonado@webrtc.org

[kjellander_webrtc, 2017-02-10 14:09:27]

I think I finally got it right. I don't like the iOS bots being moved from MB to
a much worse and error-prone format but I guess it's the price we pay for using
their recipe (which has its benefits).

[ehmaldonado_webrtc, 2017-02-15 20:15:36]

https://codereview.webrtc.org/2688103002/diff/80001/tools-webrtc/ios/client.w...
File tools-webrtc/ios/client.webrtc/iOS32_Debug.json (right):

https://codereview.webrtc.org/2688103002/diff/80001/tools-webrtc/ios/client.w...
tools-webrtc/ios/client.webrtc/iOS32_Debug.json:13: "use_goma=true"
I think you might be missing "symbol_level=1"
From 
'iOS32 Debug'
 ->
'ios_debug_static_bot_arm_device'
 ->
'debug_static_bot'
 ->
'minimal_symbols'
 ->
'symbol_level=1'

I don't know if it matters.

[kjellander_webrtc, 2017-02-15 20:27:56]

Description was changed from

==========
iOS: Use JSON for GN configuration instead of MB.

This aligns with how the ios recipe module is used in Chromium.
It should prevent breakages like one we had recently.

Also move all the directories containing JSON files into
tools-webrtc/ios/bots to make it clearer (and more similar to
Chromium).

BUG=webrtc:7140
NOTRY=True
==========

to

==========
iOS: Use JSON for GN configuration instead of MB + remove symbols.

This aligns with how the ios recipe module is used in Chromium.
It should prevent breakages like one we had recently.

It also means we're no longer setting symbol_level=1 explicitly. 
The default is 0 (no symbols), which is now what's being used.

Also move all the directories containing JSON files into
tools-webrtc/ios/bots to make it clearer (and more similar to
Chromium).

BUG=webrtc:7140, webrtc:7161
NOTRY=True
==========

[kjellander_webrtc, 2017-02-15 20:28:27]

Very interesting, this might affect
https://bugs.chromium.org/p/webrtc/issues/detail?id=7161 if we're really lucky!

https://codereview.webrtc.org/2688103002/diff/80001/tools-webrtc/ios/client.w...
File tools-webrtc/ios/client.webrtc/iOS32_Debug.json (right):

https://codereview.webrtc.org/2688103002/diff/80001/tools-webrtc/ios/client.w...
tools-webrtc/ios/client.webrtc/iOS32_Debug.json:13: "use_goma=true"
On 2017/02/15 20:15:36, ehmaldonado_webrtc wrote:
> I think you might be missing "symbol_level=1"
> From 
> 'iOS32 Debug'
>  ->
> 'ios_debug_static_bot_arm_device'
>  ->
> 'debug_static_bot'
>  ->
> 'minimal_symbols'
>  ->
> 'symbol_level=1'
> 
> I don't know if it matters.

Good catch. I don't think it matters. Chrome bots don't set it
(https://cs.chromium.org/chromium/src/ios/build/bots/chromium.mac/ios-device.json)
and the default is 0
(https://cs.chromium.org/chromium/src/build/config/compiler/compiler.gni?rcl=7...)
which means no symbols. 

It will actually be interesting to change to an identical config as Chromium,
since we have some weird issues that only happens to us, not them.
I've updated the CL description to make it clear that we're changing this.

[ehmaldonado_webrtc, 2017-02-15 20:30:30]

On 2017/02/15 20:28:27, kjellander_webrtc wrote:
> Very interesting, this might affect
> https://bugs.chromium.org/p/webrtc/issues/detail?id=7161 if we're really
lucky!
> 
>
https://codereview.webrtc.org/2688103002/diff/80001/tools-webrtc/ios/client.w...
> File tools-webrtc/ios/client.webrtc/iOS32_Debug.json (right):
> 
>
https://codereview.webrtc.org/2688103002/diff/80001/tools-webrtc/ios/client.w...
> tools-webrtc/ios/client.webrtc/iOS32_Debug.json:13: "use_goma=true"
> On 2017/02/15 20:15:36, ehmaldonado_webrtc wrote:
> > I think you might be missing "symbol_level=1"
> > From 
> > 'iOS32 Debug'
> >  ->
> > 'ios_debug_static_bot_arm_device'
> >  ->
> > 'debug_static_bot'
> >  ->
> > 'minimal_symbols'
> >  ->
> > 'symbol_level=1'
> > 
> > I don't know if it matters.
> 
> Good catch. I don't think it matters. Chrome bots don't set it
>
(https://cs.chromium.org/chromium/src/ios/build/bots/chromium.mac/ios-device.json)
> and the default is 0
>
(https://cs.chromium.org/chromium/src/build/config/compiler/compiler.gni?rcl=7...)
> which means no symbols. 
> 
> It will actually be interesting to change to an identical config as Chromium,
> since we have some weird issues that only happens to us, not them.
> I've updated the CL description to make it clear that we're changing this.

LGTM :)

[kjellander_webrtc, 2017-02-15 20:31:01]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2017-02-15 20:31:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-15 20:34:04]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487190661722360,
"parent_rev": "368b5ffecc78a0a1053eb9c81cc335a269d30760", "commit_rev":
"73f01de4edda30c419bf6daf8b91d2a0d28c06a9"}

[commit-bot: I haz the power, 2017-02-15 20:34:07]

Description was changed from

==========
iOS: Use JSON for GN configuration instead of MB + remove symbols.

This aligns with how the ios recipe module is used in Chromium.
It should prevent breakages like one we had recently.

It also means we're no longer setting symbol_level=1 explicitly. 
The default is 0 (no symbols), which is now what's being used.

Also move all the directories containing JSON files into
tools-webrtc/ios/bots to make it clearer (and more similar to
Chromium).

BUG=webrtc:7140, webrtc:7161
NOTRY=True
==========

to

==========
iOS: Use JSON for GN configuration instead of MB + remove symbols.

This aligns with how the ios recipe module is used in Chromium.
It should prevent breakages like one we had recently.

It also means we're no longer setting symbol_level=1 explicitly. 
The default is 0 (no symbols), which is now what's being used.

Also move all the directories containing JSON files into
tools-webrtc/ios/bots to make it clearer (and more similar to
Chromium).

BUG=webrtc:7140, webrtc:7161
NOTRY=True

Review-Url: https://codereview.webrtc.org/2688103002
Cr-Commit-Position: refs/heads/master@{#16633}
Committed:
https://chromium.googlesource.com/external/webrtc/+/73f01de4edda30c419bf6daf8...
==========

[commit-bot: I haz the power, 2017-02-15 20:34:08]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/73f01de4edda30c419bf6daf8...

[kjellander_webrtc, 2017-02-15 20:45:26]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.webrtc.org/2694423002/ by kjellander@webrtc.org.

The reason for reverting is: Something is different from trybots vs the commit
bots, causing it to fail when running GN: 
https://build.chromium.org/p/client.webrtc/builders/iOS32%20Release/builds/10151.